Changeset 10440

Timestamp:

04/25/08 17:57:17 (5 years ago)

Author:

daisuke_m

Message:

TwitterManagerの整理。

Location:

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter

Files:

• TODO.java (modified) (1 diff)
• action/AddTabAction.java (modified) (4 diffs)
• action/CreateFavoriteAction.java (modified) (4 diffs)
• action/FilterSettingAction.java (modified) (4 diffs)
• action/GetNewFriendTimeLineAction.java (modified) (3 diffs)
• manager/TableManager.java (modified) (3 diffs)
• manager/TwitterManager.java (modified) (7 diffs)
• views/LabelProcessor.java (modified) (4 diffs)
• views/SabotterKeyListener.java (modified) (3 diffs)
• views/SabotterView.java (modified) (13 diffs)
• views/TimeLineContentProvider.java (modified) (2 diffs)
• views/TimeLineViewLabelProvider.java (modified) (2 diffs)
• views/UnreadFilter.java (modified) (2 diffs)

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/TODO.java

@@ -25 +25 @@
         // TODO 条件フィルタリングをおこなったタイムラインを、タブに表示する。
         
+        // FIXME 自分宛@のColor/Fontよりも、未読のスタイルが優先されている。
+        
+        // FIXME こんな例外が飛んでる。
+
+/*
+java.lang.IllegalArgumentException: ImageRegistry key already in use: http://s3.amazonaws.com/twitter_production/profile_images/NNNNNNNN/XXXXXXXX.jpg
+        at org.eclipse.jface.resource.ImageRegistry.put(ImageRegistry.java:283)
+        at jp.xet.eclipse.sabotter.views.LabelProcessor.getImage(LabelProcessor.java:141)
+        at jp.xet.eclipse.sabotter.views.TimeLineViewLabelProvider.getImage(TimeLineViewLabelProvider.java:86)
+        at jp.xet.eclipse.sabotter.views.TimeLineViewLabelProvider.getColumnImage(TimeLineViewLabelProvider.java:74)
+        at org.eclipse.jface.viewers.TableColumnViewerLabelProvider.update(TableColumnViewerLabelProvider.java:71)
+        at org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerColumn.java:135)
+        at org.eclipse.jface.viewers.AbstractTableViewer.doUpdateItem(AbstractTableViewer.java:386)
+        at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run(StructuredViewer.java:466)
+        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
+        at org.eclipse.core.runtime.Platform.run(Platform.java:857)
+        at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:46)
+        at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:199)
+        at org.eclipse.jface.viewers.StructuredViewer.updateItem(StructuredViewer.java:2026)
+        at org.eclipse.jface.viewers.AbstractTableViewer.createItem(AbstractTableViewer.java:264)
+        at org.eclipse.jface.viewers.AbstractTableViewer.add(AbstractTableViewer.java:250)
+        at jp.xet.eclipse.sabotter.views.SabotterView$SabotterListener$1.run(SabotterView.java:184)
+        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
+        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:129)
+        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3659)
+        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3296)
+        at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
+        at org.eclipse.jface.window.Window.open(Window.java:796)
+        at org.eclipse.ui.texteditor.GotoLineAction.run(GotoLineAction.java:202)
+        at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
+        at org.eclipse.ui.commands.ActionHandler.execute(ActionHandler.java:185)
+        at org.eclipse.ui.internal.handlers.LegacyHandlerWrapper.execute(LegacyHandlerWrapper.java:109)
+        at org.eclipse.core.commands.Command.executeWithChecks(Command.java:475)
+        at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:429)
+        at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:165)
+        at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:470)
+        at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:821)
+        at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:879)
+        at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:568)
+        at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:510)
+        at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:126)
+        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
+        at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1141)
+        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:937)
+        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:962)
+        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:947)
+        at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:975)
+        at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:971)
+        at org.eclipse.swt.widgets.Widget.wmChar(Widget.java:1285)
+        at org.eclipse.swt.widgets.Control.WM_CHAR(Control.java:3772)
+        at org.eclipse.swt.widgets.Control.windowProc(Control.java:3672)
+        at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:291)
+        at org.eclipse.swt.widgets.Display.windowProc(Display.java:4351)
+        at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
+        at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2265)
+        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3291)
+        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
+        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
+        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
+        at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
+        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
+        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
+        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
+        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
+        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
+        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
+        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
+        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
+        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
+        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
+        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
+        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
+        at java.lang.reflect.Method.invoke(Unknown Source)
+        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
+        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
+        at org.eclipse.equinox.launcher.Main.run(Main.java:1173)
+ */
 }

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/action/AddTabAction.java

@@ -50 +50 @@
         private ILabelProvider labelProvider;
         
-        private TwitterManager twitterManager;
-        
         private CTabFolder tabFolder;
         
@@ -64 +62 @@
          * @param contentProvider
          * @param labelProvider
-         * @param twitterManager
          * @param tabFolder
          * @param listener
@@ -71 +68 @@
          */
         public AddTabAction(IContentProvider contentProvider,
-                        ILabelProvider labelProvider, TwitterManager twitterManager,
-                        CTabFolder tabFolder, ISelectionChangedListener listener,
-                        List<TableViewer> viewers) {
+                        ILabelProvider labelProvider, CTabFolder tabFolder,
+                        ISelectionChangedListener listener, List<TableViewer> viewers) {
                 super();
                 this.contentProvider = contentProvider;
                 this.labelProvider = labelProvider;
-                this.twitterManager = twitterManager;
                 this.tabFolder = tabFolder;
                 this.listener = listener;
@@ -122 +117 @@
                 viewer.setLabelProvider(labelProvider);
                 viewer.setSorter(new TimeLineSorter(viewer.getTable().getColumn(2)));
-                viewer.setInput(twitterManager);
+                viewer.setInput(TwitterManager.getInstance());
                 viewer.addSelectionChangedListener(listener);
                 viewer.getTable().addKeyListener(
-                                new SabotterKeyListener(new TableManager(viewer,
-                                                twitterManager), twitterManager));
+                                new SabotterKeyListener(new TableManager(viewer)));
                 
                 tabItem.setControl(viewer.getTable());

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/action/CreateFavoriteAction.java

@@ -21 +21 @@
         public static final String ACTION_ID = "createFavorite"; // $NON-NLS-1$
         
-        /** APIマネージャ */
-        private TwitterManager manager;
-        
         /** 結果ハンドラ */
         private TwitterListener listener;
@@ -32 +29 @@
          * 
          * @param viewers
-         * @param manager
          * @param tabFolder
          * @param listener
@@ -38 +34 @@
          */
         public CreateFavoriteAction(List<TableViewer> viewers,
-                        CTabFolder tabFolder, TwitterManager manager,
-                        TwitterListener listener) {
+                        CTabFolder tabFolder, TwitterListener listener) {
                 super(viewers, tabFolder);
-                this.manager = manager;
                 this.listener = listener;
         }
@@ -59 +53 @@
                         if (statusObj instanceof Status) {
                                 int targetStatusId = ((Status) statusObj).getId();
-                                manager.createFavorite(targetStatusId, listener);
+                                TwitterManager.getInstance().createFavorite(targetStatusId,
+                                                listener);
                         }
                 }

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/action/FilterSettingAction.java

@@ -4 +4 @@
 import java.util.List;
 
-import jp.xet.eclipse.sabotter.manager.TwitterManager;
 import jp.xet.eclipse.sabotter.views.UnreadFilter;
 
@@ -21 +20 @@
         public static final String ACTION_ID = "filterSetting"; // $NON-NLS-1$
         
-        private TwitterManager twitterManager;
-        
         private List<ViewerFilter> filters = new ArrayList<ViewerFilter>();
         
@@ -33 +30 @@
          * @param viewers
          * @param tabFolder
-         * @param twitterManager
          * @category instance creation
          */
-        public FilterSettingAction(List<TableViewer> viewers,
-                        CTabFolder tabFolder, TwitterManager twitterManager) {
+        public FilterSettingAction(List<TableViewer> viewers, CTabFolder tabFolder) {
                 super(viewers, tabFolder);
-                this.twitterManager = twitterManager;
         }
         
@@ -50 +44 @@
         public void run() {
                 if (flag) {
-                        filters.add(new UnreadFilter(twitterManager));
+                        filters.add(new UnreadFilter());
                 } else {
                         filters.clear();

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/action/GetNewFriendTimeLineAction.java

@@ -20 +20 @@
         public static final String ACTION_ID = "getNewFriendTimeLine"; // $NON-NLS-1$
         
-        /** APIマネージャ */
-        private TwitterManager manager;
-        
         /** 取得したタイムラインの非同期ハンドラ */
         private TwitterListener listener;
@@ -30 +27 @@
          * コンストラクタ。
          * 
-         * @param manager
          * @param listener
          * @category instance creation
          */
-        public GetNewFriendTimeLineAction(TwitterManager manager,
-                        TwitterListener listener) {
-                this.manager = manager;
+        public GetNewFriendTimeLineAction(TwitterListener listener) {
                 this.listener = listener;
         }
@@ -49 +43 @@
                 SabotterPlugin.log(org.eclipse.core.runtime.Status.INFO, 0,
                                 "Sabotter: update timeline on " + new Date()); // $NON-NLS-1$
-                manager.getFriendsTimeline(listener);
+                TwitterManager.getInstance().getFriendsTimeline(listener);
         }
 }

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/manager/TableManager.java

@@ -21 +21 @@
         private TableViewer viewer;
         
-        private TwitterManager twitterManager;
-        
 
         /**
@@ -28 +26 @@
          * 
          * @param viewer
-         * @param twitterManager
          * @category instance creation
          */
-        public TableManager(TableViewer viewer, TwitterManager twitterManager) {
+        public TableManager(TableViewer viewer) {
                 this.viewer = viewer;
-                this.twitterManager = twitterManager;
         }
         
@@ -41 +37 @@
         public void oldestUnread() {
                 ISelection sel =
-                                new StructuredSelection(twitterManager.getOldestUnread());
+                                new StructuredSelection(TwitterManager.getInstance()
+                                        .getOldestUnread());
                 viewer.setSelection(sel);
         }

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/manager/TwitterManager.java

@@ -1 +1 @@
 package jp.xet.eclipse.sabotter.manager;
 
-import java.util.ArrayList;
 import java.util.Comparator;
-import java.util.EventListener;
 import java.util.HashSet;
 import java.util.Iterator;
@@ -12 +10 @@
 
 import jp.xet.eclipse.sabotter.SabotterPlugin;
-import jp.xet.eclipse.sabotter.event.UserEvent;
-import jp.xet.eclipse.sabotter.event.UserEventListener;
 import jp.xet.eclipse.sabotter.preferences.PreferenceKeys;
 import jp.xet.eclipse.sabotter.preferences.SabotterPreference;
@@ -47 +43 @@
         private static TwitterManager singleton;
         
-        /** オブザーバ */
-        private List<UserEventListener> listeners =
-                        new ArrayList<UserEventListener>();
-        
         /** プリファレンス */
-        private SabotterPreference pref = SabotterPlugin.getPreference();
+        private static SabotterPreference pref = SabotterPlugin.getPreference();
         
 
@@ -81 +73 @@
         
         /**
-         * リスナーを追加します。
-         * 
-         * @param listener 追加するリスナー
-         */
-        public void addPropertyChangeListener(UserEventListener listener) {
-                listeners.add(listener);
-        }
-        
-        /**
-         * リスナーに変更を通知します。
-         * 
-         * @param propName
-         * @param status
-         */
-        public void fireUnreadChange(String propName, Status status) {
-                for (UserEventListener listener : listeners) {
-                        listener.fire(new UserEvent(propName));
-                }
-        }
-        
-        /**
-         * リスナーを削除します。
-         * 
-         * @param listener 削除するリスナー
-         */
-        public void removePropertyChangeListener(EventListener listener) {
-                listeners.remove(listener);
-        }
-        
-        /**
-         * 破棄時にコールする。
-         */
-        public void dispose() {
-                singleton = null;
-        }
-        
-        /**
          * Override method.
          * 
@@ -130 +85 @@
         
         /**
-         * シングルトンインスタンスを取得する。
+         * singletonインスタンスを取得する。
          * 
          * @return インスタンス
@@ -212 +167 @@
         public void setReaded(Status status) {
                 unread.remove(status);
-                fireUnreadChange("unread", status); // $NON-NLS-1$
         }
         
@@ -233 +187 @@
         public void setUnread(Status status) {
                 unread.add(status);
-                fireUnreadChange("unread", status); // $NON-NLS-1$
         }
         

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/views/LabelProcessor.java

@@ -36 +36 @@
 public class LabelProcessor {
         
-        private TwitterManager manager;
-        
         /** APIから取得した日付のフォーマット */
         private DateFormat dfIn =
@@ -53 +51 @@
         
 
-        /**
-         * コンストラクタ。
-         * 
-         * @param manager
-         * @category instance creation
-         */
-        public LabelProcessor(TwitterManager manager) {
-                this.manager = manager;
-        }
-        
         /**
          * 表示する名前を取得する。
@@ -239 +227 @@
          */
         public Color getBackgroundColor(Status status) {
+                TwitterManager manager = TwitterManager.getInstance();
                 if (manager.isUnread(status)) {
                         return pref.getUnreadStatusBackgroundColor();
@@ -257 +246 @@
          */
         public Color getForegroundColor(Status status) {
+                TwitterManager manager = TwitterManager.getInstance();
                 if (manager.isUnread(status)) {
                         return pref.getUnreadStatusForegroundColor();

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/views/SabotterKeyListener.java

@@ -19 +19 @@
         private TableManager tableManager;
         
-        private TwitterManager twitterManager;
-        
 
         /**
@@ -26 +24 @@
          * 
          * @param tableManager
-         * @param twitterManager
          * @category instance creation
          */
-        public SabotterKeyListener(TableManager tableManager,
-                        TwitterManager twitterManager) {
+        public SabotterKeyListener(TableManager tableManager) {
                 this.tableManager = tableManager;
-                this.twitterManager = twitterManager;
         }
         
@@ -56 +51 @@
                                 && isPressed(e, SWT.SHIFT)) {
                         // FIXME 動いてない
-                        twitterManager.setUnread(tableManager.getSelection());
+                        TwitterManager.getInstance()
+                                .setUnread(tableManager.getSelection());
                         System.out.println(e);
                 } else if (e.character == 'b' && isPressed(e, SWT.CTRL)) {
                         // FIXME 動いてない
-                        twitterManager.setReaded(tableManager.getSelection());
+                        TwitterManager.getInstance()
+                                .setReaded(tableManager.getSelection());
                 } else if (e.keyCode == SWT.ARROW_UP) {
                         // nothing to do

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/views/SabotterView.java

@@ -27 +27 @@
 import org.eclipse.jface.dialogs.MessageDialog;
 import org.eclipse.jface.viewers.DoubleClickEvent;
+import org.eclipse.jface.viewers.IContentProvider;
 import org.eclipse.jface.viewers.IDoubleClickListener;
+import org.eclipse.jface.viewers.ILabelProvider;
 import org.eclipse.jface.viewers.ISelectionChangedListener;
 import org.eclipse.jface.viewers.IStructuredSelection;
@@ -76 +78 @@
         private Map<String, Action> actions = new HashMap<String, Action>();
         
-        /** Twitterマネージャ */
-        private TwitterManager twitterManager;
-        
         /** ステータステキスト入力欄 */
         private Text txtStatusText;
@@ -89 +88 @@
         /** タブ管理クラス */
         private CTabFolder tabFolder;
+        
+        private IContentProvider contentProvider;
+        
+        private ILabelProvider labelProvider;
         
 
@@ -164 +167 @@
                         SabotterPlugin.log(org.eclipse.core.runtime.Status.INFO, 0,
                                         "Sabotter: responce recieved"); // $NON-NLS-1$
-                        if (twitterManager == null) {
-                                SabotterPlugin.log(org.eclipse.core.runtime.Status.WARNING, 0,
-                                                "Sabotter: twitterManager is null"); // $NON-NLS-1$
-                                return;
-                        }
                         
                         final List<Status> result = new ArrayList<Status>();
+                        TwitterManager twitterManager = TwitterManager.getInstance();
                         for (Status status : statuses) {
                                 if (twitterManager.isNewStatus(status)) {
@@ -206 +205 @@
          */
         public SabotterView() {
-                twitterManager = TwitterManager.getInstance();
-                twitterManager.addPropertyChangeListener(this);
-        }
-        
-        /**
-         * Override method.
-         * 
-         * @see org.eclipse.ui.part.WorkbenchPart#dispose()
-         */
-        @Override
-        public void dispose() {
-                twitterManager.removePropertyChangeListener(this);
-                twitterManager.dispose();
-                twitterManager = null;
-                super.dispose();
         }
         
@@ -247 +231 @@
                                 (IStructuredSelection) viewer.getSelection();
                 for (Object obj : selection.toList()) {
-                        twitterManager.setReaded((Status) obj);
+                        TwitterManager.getInstance().setReaded((Status) obj);
                 }
         }
@@ -278 +262 @@
                 tabFolder.setLayoutData(gd);
                 
+                contentProvider = new TimeLineContentProvider(this);
+                labelProvider = new TimeLineViewLabelProvider();
+                
                 // ---- ここから
                 
@@ -290 +277 @@
                 AddTabAction.initTable(viewer);
                 
-                viewer.setContentProvider(new TimeLineContentProvider(this));
-                viewer.setLabelProvider(new TimeLineViewLabelProvider(twitterManager));
+                viewer.setContentProvider(contentProvider);
+                viewer.setLabelProvider(labelProvider);
                 viewer.setSorter(new TimeLineSorter(viewer.getTable().getColumn(2)));
-                viewer.setInput(twitterManager);
+                viewer.setInput(TwitterManager.getInstance());
                 viewer.addSelectionChangedListener(this);
                 viewer.getTable().addKeyListener(
-                                new SabotterKeyListener(new TableManager(viewer,
-                                                twitterManager), twitterManager));
+                                new SabotterKeyListener(new TableManager(viewer)));
                 
                 tabTimeline.setControl(viewer.getTable());
@@ -376 +362 @@
         private void makeActions() {
                 Action getFriendTimeLineAction =
-                                new GetNewFriendTimeLineAction(twitterManager,
-                                                new SabotterListener());
+                                new GetNewFriendTimeLineAction(new SabotterListener());
                 getFriendTimeLineAction
                         .setText(Messages.action_get_new_friend_time_line);
@@ -388 +373 @@
                 
                 Action createFavoriteAction =
-                                new CreateFavoriteAction(viewers, tabFolder, twitterManager,
+                                new CreateFavoriteAction(viewers, tabFolder,
                                                 new TwitterAdapter());
                 createFavoriteAction.setText(Messages.action_create_favorite);
@@ -402 +387 @@
                 
                 Action filterSettingAction =
-                                new FilterSettingAction(viewers, tabFolder, twitterManager);
+                                new FilterSettingAction(viewers, tabFolder);
                 filterSettingAction.setText("filter setting"); // TODO to resource file
                 filterSettingAction.setToolTipText("setting time-line filters.");
@@ -410 +395 @@
                 
                 Action addTabAction =
-                                new AddTabAction(new TimeLineContentProvider(this),
-                                                new TimeLineViewLabelProvider(twitterManager),
-                                                twitterManager, tabFolder, this, viewers);
+                                new AddTabAction(contentProvider, labelProvider, tabFolder,
+                                                this, viewers);
                 addTabAction.setText("add new tab"); // TODO to resource file
                 addTabAction.setToolTipText("add new tab");
@@ -492 +476 @@
                 String statusText = txtStatusText.getText();
                 try {
-                        twitterManager.update(statusText);
+                        TwitterManager.getInstance().update(statusText);
                         txtStatusText.setText("");
                 } catch (TwitterException e) {

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/views/TimeLineContentProvider.java

@@ -27 +27 @@
          */
         public TimeLineContentProvider(final SabotterView view) {
+                final Display display =
+                                SabotterPlugin.getDefault().getWorkbench().getDisplay();
                 Runnable runnable = new Runnable() {
                         
                         public void run() {
+                                if (display.isDisposed() || disposed) {
+                                        return;
+                                }
                                 view.getFriendsTimeLine();
-                                
-                                Display display =
-                                                SabotterPlugin.getDefault().getWorkbench()
-                                                        .getDisplay();
-                                if (display.isDisposed() == false && disposed == false) {
-                                        display.timerExec(UPDATE_INTERVAL * 1000, this);
-                                }
+                                display.timerExec(UPDATE_INTERVAL * 1000, this);
                         }
                 };
-                Display display =
-                                SabotterPlugin.getDefault().getWorkbench().getDisplay();
                 if (display.isDisposed() == false && disposed == false) {
                         display.timerExec(UPDATE_INTERVAL * 1000, runnable);
@@ -71 +68 @@
          */
         public Object[] getElements(Object parent) {
-                TwitterManager manager = (TwitterManager) parent;
-                return manager.getAllStatuses().toArray(new Object[0]);
+                return TwitterManager.getInstance().getAllStatuses().toArray(
+                                new Object[0]);
         }
 }

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/views/TimeLineViewLabelProvider.java

@@ -1 +1 @@
 package jp.xet.eclipse.sabotter.views;
-
-import jp.xet.eclipse.sabotter.manager.TwitterManager;
 
 import org.eclipse.jface.viewers.ITableColorProvider;
@@ -22 +20 @@
         
         /** 表示文字列等の加工（色づけ等）クラス */
-        private LabelProcessor processor;
+        private LabelProcessor processor = new LabelProcessor();
         
 
-        /**
-         * コンストラクタ。
-         * 
-         * @param manager
-         * @category instance creation
-         */
-        public TimeLineViewLabelProvider(TwitterManager manager) {
-                processor = new LabelProcessor(manager);
-        }
-        
         /**
          * Override method.

lang/java/sabotter/trunk/src/jp/xet/eclipse/sabotter/views/UnreadFilter.java

@@ -15 +15 @@
 public class UnreadFilter extends ViewerFilter {
         
-        private TwitterManager twitterManager;
-        
-
-        /**
-         * コンストラクタ。
-         * 
-         * @param twitterManager
-         * @category instance creation
-         */
-        public UnreadFilter(TwitterManager twitterManager) {
-                this.twitterManager = twitterManager;
-        }
-        
         /**
          * Overriding method.
@@ -37 +24 @@
         public boolean select(Viewer viewer, Object parentElement, Object element) {
                 Status status = (Status) element;
-                if (twitterManager.isUnread(status)) {
+                if (TwitterManager.getInstance().isUnread(status)) {
                         return true;
                 }