Changeset 11693

Timestamp:

05/16/08 14:27:00 (5 years ago)

Author:

tokuhirom

Message:

r13917@o193-156: tokuhirom | 2008-05-16 12:19:00 +0900
oops. $upload->basename was broken :( fixed.

Location:

lang/perl/HTTP-Engine/trunk

Files:

• lib/HTTP/Engine/Request/Upload.pm (modified) (2 diffs)
• t/17_upload-basename.t (added)

lang/perl/HTTP-Engine/trunk/lib/HTTP/Engine/Request/Upload.pm

@@ -12 +12 @@
 has tempname => ( is => 'rw' );
 has type     => ( is => 'rw' );
-has basename => ( is => 'rw' );
+has basename => (
+    is      => 'rw',
+    lazy    => 1,
+    default => sub {
+        my $self = shift;
+        my $basename = $self->filename;
+        $basename =~ s|\\|/|g;
+        $basename = ( File::Spec::Unix->splitpath($basename) )[2];
+        $basename =~ s|[^\w\.-]+|_|g;
+        $basename;
+    }
+);
 
 has fh => (
@@ -57 +68 @@
 
     $content;
-}
-
-sub basename {
-    my $self = shift;
-
-    unless ( $self->{basename} ) {
-        my $basename = $self->filename;
-        $basename =~ s|\\|/|g;
-        $basename = ( File::Spec::Unix->splitpath($basename) )[2];
-        $basename =~ s|[^\w\.-]+|_|g;
-        $self->{basename} = $basename;
-    }
-    $self->{basename};
 }