Changeset 12501

Timestamp:

05/27/08 08:05:37 (5 years ago)

Author:

daisuke

Message:

* now support arrayref keys for all get/set operations
* slight modifications for stats

Location:

lang/perl/Cache-Memcached-libmemcached/trunk

Files:

• lib/Cache/Memcached/libmemcached.pm (modified) (4 diffs)
• t/02_basic.t (modified) (2 diffs)

lang/perl/Cache-Memcached-libmemcached/trunk/lib/Cache/Memcached/libmemcached.pm

@@ -39 +39 @@
             sub $method { 
                 my \$self = shift;
-                \$self->memcached_$method(\$self->{namespace} . \$_[0], \$_[1], int(\$_[2] || 0))
+                my (\$master_key, \$key) = \$self->__to_keys(shift);
+                if (\$master_key) {
+                    \$self->SUPER::memcached_${method}_by_key(\$master_key, \$key, \@_);
+                } else {
+                    \$self->SUPER::memcached_${method}(\$key, \@_);
+                }
             }
         EOSUB
@@ -108 +113 @@
 }
 
-sub get
+sub __to_keys
 {
     my $self = shift;
     my $key  = shift;
-    $self->SUPER::get($self->{namespace} . $key, @_);
+
+    my $master_key;
+    if (ref $key eq 'ARRAY') {
+        ($master_key, $key) = @$key;
+    }
+
+    if ($self->{namespace}) {
+        $key .= "$self->{namespace}$key";
+    }
+    return ($master_key, $key);
+}
+
+sub get
+{
+    my $self = shift;
+    my ($master_key, $key) = $self->__to_keys(shift);
+    $self->SUPER::get($master_key ? [$master_key, $key] : $key, @_);
 }
 
@@ -210 +231 @@
         $h{hosts}{$hostport}{$type}{$key} = $value;
         if ($type eq 'misc') {
-            $h{total}{$key} += $value if $misc_keys{$key};
+            if ($misc_keys{$key}) {
+                $h{total}{$key} ||= 0;
+                $h{total}{$key} += $value;
+            }
         } elsif ($type eq 'malloc') {
+            $h{total}{"malloc_$key"} ||= 0;
             $h{total}{"malloc_$key"} += $value;
         }
@@ -340 +365 @@
 =over 4
 
-=item cas() and stats() are not implemented
-
-They were sort of implemented in a previous life, but since 
-Memcached::libmemcached is still undecided how to handle these, we don't
+=item cas() is not implemented
+
+This was sort of implemented in a previous life, but since 
+Memcached::libmemcached is still undecided how to handle it, we don't
 support it either.
 

lang/perl/Cache-Memcached-libmemcached/trunk/t/02_basic.t

@@ -7 +7 @@
         plan(skip_all => "Define MEMCACHED_SERVER (e.g. localhost:11211) to run this test");
     } else {
-        plan(tests => 21);
+        plan(tests => 22);
     }
     use_ok("Cache::Memcached::libmemcached");
@@ -79 +79 @@
     ok(!$cache->get_compress_enable, "check explicit compress_enable => 0");
 }
+
+{
+    $cache = Cache::Memcached::libmemcached->new({
+        servers => [ $ENV{ MEMCACHED_SERVER } ],
+        compress_enable => 1,
+    });
+
+    my $master_key = 'dummy_master';
+    my $key        = 'foo_with_master';
+    $cache->set([ $master_key, $key ], 100);
+    is( $cache->get([ $master_key, $key ]), 100, "get with master key" );
+}