Changeset 12605 for lang/perl/HTTPEx-Declare

Timestamp:

05/28/08 19:26:45 (5 years ago)

Author:

tokuhirom

Message:

more smart.

Location:

lang/perl/HTTPEx-Declare/trunk

Files:

• lib/HTTPEx/Declare.pm (modified) (1 diff)
• t/perlcriticrc (modified) (1 diff)

lang/perl/HTTPEx-Declare/trunk/lib/HTTPEx/Declare.pm

@@ -1 +1 @@
 package HTTPEx::Declare;
-
 use strict;
 use warnings;
 our $VERSION = '0.01';
-
-use Sub::Name 'subname';
-use Sub::Exporter;
-
 use HTTP::Engine;
+use Sub::Exporter -setup => {
+    exports => [qw/middlewares interface run/],
+    groups  => { default => [':all'] }
+};
 
 my $interface;
 
-my %exports = (
-    middlewares => sub {
-        subname 'HTTPEx::Declare::middlewares' => sub (@) {
-            HTTP::Engine->load_middlewares( @_ );
-        }
-    },
-    interface => sub {
-        subname 'HTTPEx::Declare::interface' => sub ($$) {
-            $interface = {
-                module => shift,
-                args   => shift,
-            };
-        }
-    },
-    run => sub {
-        subname 'HTTPEx::Declare::run' => sub (&;@) {
-            unless ($interface) {
-                require Carp;
-                Carp::croak 'please define interface previously';
-            }
-            my $request_handler = shift;
-            my $engine = HTTP::Engine->new(
-                interface => {
-                    module          => $interface->{module},
-                    args            => $interface->{args},
-                    request_handler => $request_handler,
-                },
-            );
-            undef $interface;
-            $engine->run(@_);
-        }
-    },
-);
+sub middlewares (@) {
+    HTTP::Engine->load_middlewares(@_);
+}
 
-Sub::Exporter::setup_exporter({
-    exports => \%exports,
-    groups  => { default => [':all'] }
-});
+sub interface($$) {
+    $interface = {
+        module => shift,
+        args   => shift,
+    };
+}
+
+sub run(&;@) {
+    unless ($interface) {
+        require Carp;
+        Carp::croak 'please define interface previously';
+    }
+    my $request_handler = shift;
+    my $engine          = HTTP::Engine->new(
+        interface => {
+            module          => $interface->{module},
+            args            => $interface->{args},
+            request_handler => $request_handler,
+        },
+    );
+    undef $interface;
+    $engine->run(@_);
+}
 
 1;

lang/perl/HTTPEx-Declare/trunk/t/perlcriticrc

@@ -1 +1 @@
 [TestingAndDebugging::ProhibitNoStrict]
 allow=refs
+
+[Subroutines::ProhibitSubroutinePrototypes]
+severity = cruel