Changeset 12891

Timestamp:

05/31/08 11:37:53 (5 years ago)

Author:

tokuhirom

Message:

use Params::Validate

Location:

lang/perl/mobirc/trunk

Files:

• CONCEPT (modified) (1 diff)
• lib/App/Mobirc/HTTPD/C/Ajax.pm (modified) (1 diff)
• lib/App/Mobirc/HTTPD/Template/Ajax.pm (modified) (1 diff)
• t/HTTPD/Template/Ajax/channel.t (added)

lang/perl/mobirc/trunk/CONCEPT

@@ +1 @@
+■コアコンセプト
+- 綺麗なコード
+- CPAN モジュールはいっぱいつかっていい
+
+■etc.
 - HTTPD::Template の中身はけっして req, res に関する情報を知ってはいけない。
 -- module の独立性をたもつため
 - C からよばれる Template はすべて validate() をつかう
-
+- MooseX::Plaggerize をつかう

lang/perl/mobirc/trunk/lib/App/Mobirc/HTTPD/C/Ajax.pm

@@ -25 +25 @@
         $c,
         'ajax/channel' => (
-            $channel,
-            irc_nick
+            channel  => $channel,
+            irc_nick => irc_nick,
         )
     );

lang/perl/mobirc/trunk/lib/App/Mobirc/HTTPD/Template/Ajax.pm

@@ -116 +116 @@
 
 template 'ajax/channel' => sub {
-    my ($self, $channel, $irc_nick) = @_;
+    my $self = shift;
+    my %args = validate(
+        @_ => {
+            channel  => 1,
+            irc_nick => 1,
+        },
+    );
     div {
-        for my $message ($channel->message_log) {
-            show '../irc_message', $message, $irc_nick;
+        for my $message ($args{channel}->message_log) {
+            show '../irc_message', $message, $args{irc_nick};
             br { };
         }