Changeset 12990 for lang

Timestamp:

06/01/08 20:08:58 (5 years ago)

Author:

tokuhirom

Message:

fixed a lot of bugs

Location:

lang/perl/mobirc/branches/plaggerize

Files:

• CONCEPT (modified) (1 diff)
• lib/App/Mobirc/HTTPD/C.pm (modified) (1 diff)
• lib/App/Mobirc/HTTPD/C/Mobile.pm (modified) (1 diff)
• lib/App/Mobirc/HTTPD/Handler.pm (modified) (2 diffs)
• lib/App/Mobirc/Plugin/Authorizer/Cookie.pm (modified) (3 diffs)
• lib/App/Mobirc/Plugin/DocRoot.pm (modified) (2 diffs)
• lib/App/Mobirc/Plugin/HTMLFilter/ConvertPictograms.pm (modified) (1 diff)
• lib/App/Mobirc/Plugin/HTMLFilter/DoCoMoCSS.pm (modified) (1 diff)
• lib/App/Mobirc/Validator.pm (added)

lang/perl/mobirc/branches/plaggerize/CONCEPT

@@ -20 +20 @@
 -- HTTPD::* => Web::*
 -- hirose31's Groups => Hook.
+-- validate_hook を、もうちょいなんとかかっこよく実装したい。
+

lang/perl/mobirc/branches/plaggerize/lib/App/Mobirc/HTTPD/C.pm

@@ -39 +39 @@
     $c->res->body( $content );
 
-    context->run_hook('response_filter');
+    context->run_hook('response_filter', $c);
 }
 

lang/perl/mobirc/branches/plaggerize/lib/App/Mobirc/HTTPD/C/Mobile.pm

@@ -122 +122 @@
             recent_mode         => $c->req->params->{recent_mode},
             message             => $c->req->params->{'msg'} || '',
-            channel_page_option => [
-                context->run_hook('channel_page_option', $channel, $c)
-            ],
+            channel_page_option => context->run_hook('channel_page_option', $channel, $c),
             irc_nick            => irc_nick,
         }

lang/perl/mobirc/branches/plaggerize/lib/App/Mobirc/HTTPD/Handler.pm

@@ -17 +17 @@
     my $c = shift;
 
-    context->run_hook('request_filter');
+    context->run_hook('request_filter', $c);
 
     if (authorize($c)) {
@@ -24 +24 @@
             $c->res->set_http_response($response);
         }
-        context->run_hook('response_filter');
+        context->run_hook('response_filter', $c);
     } else {
         $c->res->status(401);

lang/perl/mobirc/branches/plaggerize/lib/App/Mobirc/Plugin/Authorizer/Cookie.pm

@@ -7 +7 @@
 use Digest::MD5 ();
 use Encode;
+use App::Mobirc::Validator;
 
 has password => (
@@ -21 +22 @@
 
 hook authorize => sub {
-    my ( $self, $global_context, $c, ) = @_;
+    my ( $self, $global_context, $c, ) = validate_hook('authorize', @_);
 
     my $cookie_str = $c->req->header('Cookie');
@@ -41 +42 @@
 
 hook response_filter => sub {
-    my ($self, $global_context, $c) = @_;
+    my ($self, $global_context, $c) = validate_hook('response_filter', @_);
 
     $c->res->cookies->{mobirc_key} = CGI::Cookie->new(

lang/perl/mobirc/branches/plaggerize/lib/App/Mobirc/Plugin/DocRoot.pm

@@ -5 +5 @@
 use XML::LibXML;
 use Encode;
+use Params::Validate ':all';
 
 has root => (
@@ -13 +14 @@
 
 hook request_filter => sub {
-    my ($self, $global_context, $c) = @_;
+    my ($self, $global_context, $c) = validate_pos(@_,
+        { isa => __PACKAGE__ },
+        { isa => 'App::Mobirc' },
+        { isa => 'HTTP::Engine::Context' },
+    );
 
     my $root = $self->root;

lang/perl/mobirc/branches/plaggerize/lib/App/Mobirc/Plugin/HTMLFilter/ConvertPictograms.pm

@@ -3 +3 @@
 use MooseX::Plaggerize::Plugin;
 use HTML::Entities::ConvertPictogramMobileJp qw(convert_pictogram_entities);
+use Params::Validate ':all';
 
 hook html_filter => sub {
-    my ( $self, $global_context, $c, $content ) = @_;
+    my ($self, $global_context, $c, $content) = validate_pos(@_,
+        { isa => __PACKAGE__ },
+        { isa => 'App::Mobirc' },
+        { isa => 'HTTP::Engine::Context' },
+        { type => SCALAR },
+    );
 
     return (

lang/perl/mobirc/branches/plaggerize/lib/App/Mobirc/Plugin/HTMLFilter/DoCoMoCSS.pm

@@ -13 +13 @@
 
     DEBUG "FILTER DOCOMO CSS";
-    return $content unless $c->req->mobile_agent->is_docomo;
+    return ($c, $content) unless $c->req->mobile_agent->is_docomo;
 
     # escape Numeric character reference.