Changeset 15788 for lang/perl/Data-Valve

Timestamp:

07/14/08 15:49:12 (5 years ago)

Author:

daisuke

Message:

refactor where the lock mechanism is

Location:

lang/perl/Data-Valve/trunk/lib/Data/Valve/BucketStore

Files:

• Memcached.pm (modified) (1 diff)
• Object.pm (modified) (1 diff)
• WithKeyedMutex.pm (modified) (2 diffs)

lang/perl/Data-Valve/trunk/lib/Data/Valve/BucketStore/Memcached.pm

@@ -32 +32 @@
     coerce   => 1,
     required => 1,
+    default  => sub {
+        Class::MOP::load_class('Cache::Memcached');
+        Cache::Memcached->new({
+            servers => [ '127.0.0.1:11211' ]
+        });
+    }
 );
 

lang/perl/Data-Valve/trunk/lib/Data/Valve/BucketStore/Object.pm

@@ -29 +29 @@
     my $key = $args{key};
 
-    my $mutex = $self->mutex;
-
     my $rv;
     my $done = 0;
     my $store = $self->store;
     while ( ! $done) {
-        my $lock = $mutex ? $mutex->lock($key, 1) : 1;
+        my $lock = $self->lock($key);
         next unless $lock;
 

lang/perl/Data-Valve/trunk/lib/Data/Valve/BucketStore/WithKeyedMutex.pm

@@ -28 +28 @@
     my $self = shift;
 
-
     # if no keyedmutex was provided explicitly, we attempt to create one
     # however, if the creation of this object fails, well, we can go
@@ -42 +41 @@
 }
 
+sub lock {
+    my ($self, $key) = @_;
+
+    my $mutex = $self->mutex;
+    return 1 unless $mutex;
+    my $rv = eval { $mutex->lock($key, 1) };
+    # if in case an error has been reported, we should ditch the mutex,
+    # cause it will keep giving errors (or worse yet, crash)
+    if ($@) {
+        $self->mutex(undef);
+    }
+    return $rv;
+}
+
 1;