Changeset 18008

Timestamp:

08/22/08 05:39:49 (5 years ago)

Author:

tokuhirom

Message:

added test case for Authorizer::BasicAuth?
fixed bugs around A::Basic

Location:

lang/perl/Nanto/trunk

Files:

• lib/Nanto/Web/Plugin/Authorizer/Basic.pm (modified) (3 diffs)
• t/030_web_plugin/Authorizer-BasicAuth.t (modified) (1 diff)
• t/Utils.pm (modified) (3 diffs)

lang/perl/Nanto/trunk/lib/Nanto/Web/Plugin/Authorizer/Basic.pm

@@ -5 +5 @@
     is       => 'ro',
     isa      => 'ArrayRef[HashRef]',
+    required => 1,
+);
+
+has 'realm' => (
+    is       => 'ro',
+    isa      => 'Str',
     required => 1,
 );
@@ -17 +23 @@
             status => 401,
             headers => {
-                'WWW-Authenticate' => qq(Basic Realm="ulgori")
+                'WWW-Authenticate' => qq(Basic Realm="@{[ $self->realm ]}")
             },
         );
@@ -30 +36 @@
         my $sent_cred = $req->headers->authorization_basic;
         if ($sent_cred && $sent_cred eq $cred) {
-            DEBUG "BASIC AUTH OK";
-            return 1;
+            return 1; ### ok
         }
     }
 
-    return 0; # failed
+    return 0; ### failed
 }
 

lang/perl/Nanto/trunk/t/030_web_plugin/Authorizer-BasicAuth.t

@@ -1 +1 @@
 use strict;
 use warnings;
-use HTTP::Engine;
+use t::Utils;
+use Test::More tests => 5;
 
-HTTP::Engine->new(
-    interface => {
-        module => 'Test',
-        request_handler => sub {
-        },
-    },
-);
+handler->load_plugin({
+    module => 'Authorizer::Basic',
+    config => {
+        acl => [
+            {username => 'foo', password => 'bar'},
+        ],
+        realm => 'this is test',
+    }
+});
+
+# no pass
+do {
+    my $res = run_engine(
+        'GET', '/'
+    );
+    is $res->code, 401;
+    is $res->www_authenticate, 'Basic Realm="this is test"';
+};
+
+# invalid pass
+do {
+    my $res = run_engine(
+        'GET', '/', do {
+            my $headers = HTTP::Headers->new();
+            $headers->authorization_basic('foo', 'iyan');
+            $headers;
+        }
+    );
+    is $res->code, 401;
+    is $res->www_authenticate, 'Basic Realm="this is test"';
+};
+
+# success
+do {
+    my $res = run_engine(
+        'GET', '/', do {
+            my $headers = HTTP::Headers->new();
+            $headers->authorization_basic('foo', 'bar');
+            $headers;
+        }
+    );
+    is $res->code, 200;
+};
+

lang/perl/Nanto/trunk/t/Utils.pm

@@ -6 +6 @@
 use lib 't/lib';
 use Foo::Web::Dispatcher;
+use Nanto::ClassLoader;
+use Nanto::Web::Handler;
+use HTTP::Engine;
 
 my $handler;
-sub handler {
+sub handler() {
     $handler ||= Nanto::Web::Handler->new(
         dispatcher => 'Foo::Web::Dispatcher',
@@ -19 +22 @@
 
 sub run_engine {
-    my $req = shift;
+    my @args = @_;
     my $res = HTTP::Engine->new(
         interface => {
@@ -29 +32 @@
             },
         },
-    )->run($req);
+    )->run(HTTP::Request->new( @args ));
     return $res;
 }