Changeset 20988

Timestamp:

10/08/08 23:28:16 (3 months ago)

Author:

tokuhirom

Message:

added node.getAttribute.

Location:

lang/cplusplus/llv8call/trunk

Files:

• ext/libxml/element.cc (modified) (3 diffs)
• t/070_libxml/02_dom.js (modified) (2 diffs)

lang/cplusplus/llv8call/trunk/ext/libxml/element.cc

@@ -30 +30 @@
     xmlNodeAddContent(node, (const xmlChar*)*content);
     return Undefined();
+END
+
+FUNCTION(getAttribute)
+    ARG_COUNT(1);
+    ARG_str(name, 0);
+    EXTERNAL_NODE();
+    xmlChar* ret = xmlGetNoNsProp(node, (xmlChar*)*name);
+    if (ret) {
+        Handle<String> s = String::New((const char*)ret);
+        xmlFree(ret);
+        return s;
+    } else {
+        return Undefined();
+    }
 END
 
@@ -65 +79 @@
     BIND_IM("appendText",       appendText);
     BIND_IM("appendTextNode",   appendText); // alias
+    BIND_IM("getAttribute",     getAttribute);
     setupNodeIM(OBJECT_TEMPLATE);
     EXPORT_CLASS("Element");
@@ -73 +88 @@
 // TODO: elem.setAttribute
 // TODO: elem.setAttributeNS
-// TODO: elem.getAttribute
 // TODO: elem.getAttributeNS
 // TODO: elem.getAttributeNode

lang/cplusplus/llv8call/trunk/t/070_libxml/02_dom.js

@@ -1 +1 @@
 require('t/util.js');
 
-plan({tests:23});
+plan({tests:25});
 
 check_lib("org.coderepos.libxml");
@@ -101 +101 @@
     is(root.toString(),  '<foo foo="baz"/>',               'doc.createAttribute()');
     is(attr.getOwnerElement().toString(), root.toString(), "attr.getOwnerElement");
+    is(root.getAttribute("foo"),  'baz',                   'node.getAttribute()');
+    is(root.getAttribute("notfound"),  undefined,          'node.getAttribute()');
 });