Changeset 21008

Timestamp:

10/09/08 00:24:16 (3 months ago)

Author:

tokuhirom

Message:

added elem.removeAttribute

Location:

lang/cplusplus/llv8call/trunk

Files:

• ext/libxml/element.cc (modified) (3 diffs)
• t/070_libxml/02_dom.js (modified) (2 diffs)

lang/cplusplus/llv8call/trunk/ext/libxml/element.cc

@@ -63 +63 @@
 END
 
+FUNCTION(removeAttribute)
+    ARG_COUNT(1);
+    ARG_str(name, 0);
+    EXTERNAL_NODE();
+    xmlAttrPtr attr = domGetAttrNode(node, (const xmlChar*)*name);
+    if (attr) {
+        xmlUnlinkNode((xmlNodePtr)attr);
+    }
+    return Undefined();
+END
+
 FUNCTION(setAttributeNode)
     ARG_COUNT(1);
@@ -98 +109 @@
     BIND_IM("getAttribute",     getAttribute);
     BIND_IM("hasAttribute",     hasAttribute);
+    BIND_IM("removeAttribute",  removeAttribute);
     setupNodeIM(OBJECT_TEMPLATE);
     EXPORT_CLASS("Element");
 ENDSUBMODULE
 
-// REST: 6/24
+// REST: 7/24
 // TODO: elem.setAttribute
 // TODO: elem.setAttributeNS
@@ -108 +120 @@
 // TODO: elem.getAttributeNode
 // TODO: elem.getAttributeNodeNS
-// TODO: elem.removeAttribute
 // TODO: elem.removeAttributeNS
 // TODO: elem.hasAttributeNS

lang/cplusplus/llv8call/trunk/t/070_libxml/02_dom.js

@@ -1 +1 @@
 require('t/util.js');
 
-plan({tests:37});
+plan({tests:39});
 
 check_lib("org.coderepos.libxml");
@@ -147 +147 @@
 });
 
+test(function () {
+    root.setAttributeNode(doc.createAttribute("foo", "bar"));
+    is(root.toString(),  '<foo foo="bar"/>',               'doc.createAttribute()');
+    root.removeAttribute("foo");
+    is(root.toString(),  '<foo/>',                        'doc.createAttribute()');
+});
+
 doc.close();