Changeset 2102 for lang/perl/Class-Hookable

Timestamp:

11/28/07 13:34:40 (14 months ago)

Author:

nyarla

Message:

lang/perl/Class-Hookable: I renamed metod: hooks -> hookable_all_hooks

Location:

lang/perl/Class-Hookable/trunk

Files:

• lib/Class/Hookable.pm (modified) (12 diffs)
• t/02_register/00_register_hook.t (modified) (2 diffs)

lang/perl/Class-Hookable/trunk/lib/Class/Hookable.pm

@@ -10 +10 @@
 
 sub new { bless {}, shift }
-
-sub hooks {
-    my ( $self ) =  @_;
-
-    if ( ref $self->{'Class::Hookable'} ne 'HASH' ) {
-        $self->{'Class::Hookable'} = {
-            hooks => {},
-        };
-    }
-
-    return $self->{'Class::Hookable'}->{'hooks'};
-}
 
 sub hookable_stash {
@@ -52 +40 @@
 }
 
+sub hookable_all_hooks {
+    my $self = shift;
+    return $self->hookable_stash->{'hooks'};
+}
+
 sub hookable_set_filter {
     my ( $self, @filters ) = @_;
@@ -113 +106 @@
 
         if ( $self->hookable_call_filter( 'register_hook', $hook, $action ) ) {
-            $self->hooks->{$hook} = []
-                if ( ref $self->hooks->{$hook} ne 'ARRAY' );
-
-            push @{ $self->hooks->{$hook} }, $action;
+            $self->hookable_all_hooks->{$hook} = []
+                if ( ref $self->hookable_all_hooks->{$hook} ne 'ARRAY' );
+
+            push @{ $self->hookable_all_hooks->{$hook} }, $action;
         }
     }
@@ -131 +124 @@
     my @hooks = ();
 
-    for my $hook ( keys %{ $self->hooks } ) {
-        for my $action ( @{ $self->hooks->{$hook} } ) {
+    for my $hook ( keys %{ $self->hookable_all_hooks } ) {
+        for my $action ( @{ $self->hookable_all_hooks->{$hook} } ) {
             my $plugin = $action->{'plugin'};
             my $class  = ref $plugin || $plugin;
@@ -152 +145 @@
     Carp::croak "Hook name is not specified." if ( ! defined $hook );
 
-    my $list = $self->hooks->{$hook};
+    my $list = $self->hookable_all_hooks->{$hook};
        $list ||= [];
 
@@ -166 +159 @@
 
     my $is_class = ( ! ref $object ) ? 1  : 0 ;
-    @hooks = keys %{ $self->hooks } if ( @hooks == 0 );
+    @hooks = keys %{ $self->hookable_all_hooks } if ( @hooks == 0 );
 
     for my $hook ( $self->registered_hooks( $object ) ) {
@@ -183 +176 @@
         }
 
-        $self->hooks->{$hook} = \@actions;
+        $self->hookable_all_hooks->{$hook} = \@actions;
     }
 
@@ -194 +187 @@
 
     if ( @plugins == 0 ) {
-        $self->hooks->{$hook} = [];
+        $self->hookable_all_hooks->{$hook} = [];
     }
     else {
@@ -276 +269 @@
 Nothing but that is being done.
 
-=head2 hookable_stash
-
-  my $data = $hook->hookable_stash;
-
-This method is stash in Class::Hookable.
-All variables Class::Hookable needs are put here.
-
-This method does not get arguments,
-and return hash reference includes all variables.
-
-=head2 hookable_context
-
-  # set
-  $hook->hookable_context( $context );
-  # get
-  my $context = $hook->hookable_context;
-
-This method is accessor of context object.
-
-blessed object or class name is specified as the context object.
-
-Context object specified by this method is passed as the second argument of
-the subroutine registered with hook and method.
-
-see also L<"run_hook">.
-
 =head1 REGISTER METOHDS
 
@@ -418 +385 @@
 =item C<$args>
 
-C<$args> specified by the run_hook method.
+the argument specified by the run_hook method.
 
 =back
 
+B<Arguments of C<$hook-E<gt>hookable_call_filter>>:
+
+  $hook->hookable_call_filter( 'run_hook', $hook, $args, $action );
 
 Only when C<$hook-E<gt>hookable_call_filter( 'run_hook', $hook, $args, $action )> has returned truth,
@@ -427 +397 @@
 
 Please see L<"hookable_call_filter"> about C<$hook-E<gt>hookable_call_filter>.
-
-B<Arguments of C<$hook-E<gt>hookable_call_filter>>:
-
-  $hook->hookable_call_filter( 'run_hook', $hook, $args, $action );
 
 =over 4
@@ -591 +557 @@
 =head1 ACCESSOR METOHDS
 
-=head2 hooks
-
-  my $hooks = $hook->hooks;
+=head2 hookable_stash
+
+  my $data = $hook->hookable_stash;
+
+This method is stash in Class::Hookable.
+All variables Class::Hookable needs are put here.
+
+This method does not get arguments,
+and return hash reference includes all variables.
+
+=head2 hookable_context
+
+  # set
+  $hook->hookable_context( $context );
+  # get
+  my $context = $hook->hookable_context;
+
+This method is accessor of context object.
+
+blessed object or class name is specified as the context object.
+
+Context object specified by this method is passed as the second argument of
+the subroutine registered with hook and method.
+
+see also L<"run_hook">.
+
+=head2 hookable_all_hooks
+
+  my $hooks = $hook->hookable_all_hooks;
 
 This method is accessor to hash reference which keeps hooks.

lang/perl/Class-Hookable/trunk/t/02_register/00_register_hook.t

@@ -16 +16 @@
 
 is(
-    $hook->hooks->{'foo.bar'}->[0]->{'plugin'},
+    $hook->hookable_all_hooks->{'foo.bar'}->[0]->{'plugin'},
     $plugin,
 );
 
 is(
-    $hook->hooks->{'foo.bar'}->[0]->{'callback'},
+    $hook->hookable_all_hooks->{'foo.bar'}->[0]->{'callback'},
     $plugin->can('foo'),
 );
@@ -47 +47 @@
 
 is(
-    $hook->hooks->{'foo.bar'}->[1],
+    $hook->hookable_all_hooks->{'foo.bar'}->[1],
     undef,
 );