Changeset 21023

Timestamp:

10/09/08 08:48:31 (3 months ago)

Author:

tokuhirom

Message:

added node.getAttributeNode()

Location:

lang/cplusplus/llv8call/trunk

Files:

• ext/libxml/element.cc (modified) (2 diffs)
• ext/libxml/libxml.h (modified) (1 diff)
• t/070_libxml/02_dom.js (modified) (2 diffs)

lang/cplusplus/llv8call/trunk/ext/libxml/element.cc

@@ -47 +47 @@
         xmlFree(ret);
         return s;
+    } else {
+        return Undefined();
+    }
+END
+
+FUNCTION(getAttributeNode)
+    ARG_COUNT(1);
+    ARG_str(name, 0);
+    EXTERNAL_NODE();
+    EXTERNAL_DOC();
+    xmlAttrPtr attr = domGetAttrNode(node, (const xmlChar*)*name);
+    if (attr) {
+        return CREATE_ATTR(doc, attr);
     } else {
         return Undefined();
@@ -108 +121 @@
     BIND_IM("appendTextNode",   appendText); // alias
     BIND_IM("getAttribute",     getAttribute);
+    BIND_IM("getAttributeNode", getAttributeNode);
     BIND_IM("hasAttribute",     hasAttribute);
     BIND_IM("removeAttribute",  removeAttribute);

lang/cplusplus/llv8call/trunk/ext/libxml/libxml.h

@@ -35 +35 @@
 }
 
-#define CREATE_NODE(doc, node) createObject("Node",      doc, node)
-#define CREATE_ATTR(doc, node) createObject("Attribute", doc, node)
+#define CREATE_NODE(doc, node) createObject("Node", doc, node)
+#define CREATE_ATTR(doc, node) createObject("Attr", doc, (xmlNodePtr)node)
 
 #define ARG_node(name, n) EXTERNAL(xmlNodePtr, name, args[n]->ToObject(), 0)

lang/cplusplus/llv8call/trunk/t/070_libxml/02_dom.js

@@ -1 +1 @@
 require('t/util.js');
 
-plan({tests:42});
+plan({tests:44});
 
 check_lib("org.coderepos.libxml");
@@ -162 +162 @@
 });
 
+test(function () {
+    root.setAttributeNode(doc.createAttribute("foo", "bar"));
+    is(root.getAttributeNode('foo').getValue(),  'bar',               'node.getAttributeNode()');
+    is(root.getAttributeNode('noo'),             undefined,           'node.getAttributeNode()');
+});
+
 doc.close();