Changeset 21622

Timestamp:

10/19/08 15:52:09 (5 years ago)

Author:

lyokato

Message:

lang/perl/OAuth-Lite: Checking in changes prior to tagging of version 1.14. Changelog diff is:

Index: Changes
===================================================================
--- Changes (revision 21609)
+++ Changes (working copy)
@@ -1,5 +1,9 @@

Revision history for Perl extension OAuth::Lite.

+1.14 San Oct 19 15:37:00 2008
+ - Consumer and Util now can handle arrayref parameters for such as checkbox values.
+ Thanks to Evaldas Imbrasas.
+

1.13 Thu Oct 08 10:34:00 2008

• Consumer now doesn't inherit LWP::UserAgent? but delegate.
  
• Server::mod_perl2: fixed point that building regularized uri for proxy usage. borrowed code from Catalyst::Engine::Apache.
  

Location:

lang/perl/OAuth-Lite/trunk

Files:

• Changes (modified) (1 diff)
• lib/OAuth/Lite.pm (modified) (1 diff)
• lib/OAuth/Lite/Consumer.pm (modified) (2 diffs)
• lib/OAuth/Lite/Util.pm (modified) (4 diffs)
• t/01_util.t (modified) (2 diffs)

lang/perl/OAuth-Lite/trunk/Changes

@@ -1 +1 @@
 Revision history for Perl extension OAuth::Lite.
+
+1.14  San Oct 19 15:37:00 2008
+    - Consumer and Util now can handle arrayref parameters for such as checkbox values.
+      Thanks to Evaldas Imbrasas.
 
 1.13  Thu Oct 08 10:34:00 2008

lang/perl/OAuth-Lite/trunk/lib/OAuth/Lite.pm

@@ -4 +4 @@
 use warnings;
 
-our $VERSION = "1.13";
+our $VERSION = "1.14";
 our $OAUTH_DEFAULT_VERSION = "1.0";
 

lang/perl/OAuth-Lite/trunk/lib/OAuth/Lite/Consumer.pm

@@ -536 +536 @@
         $headers->header( Authorization => $header );
         if (keys %$extra > 0) {
-            my $data = join('&', map(sprintf(q{%s=%s},
-                encode_param($_), encode_param($extra->{$_}) ), keys %$extra));
+            my $data = normalize_params($extra);
+            #my $data = join('&', @extra_pairs);
             if (any { $method eq $_ } @send_data_methods) {
                 $content = $data;
@@ -677 +677 @@
         map(sprintf(q{%s=%s}, encode_param($_), encode_param($all{$_})),
         keys %all));
-    $query;
+    normalize_params({%all});
 }
 

lang/perl/OAuth-Lite/trunk/lib/OAuth/Lite/Util.pm

@@ -18 +18 @@
     parse_auth_header
     build_auth_header
+    normalize_params
 /]);
 
@@ -112 +113 @@
     my ($method, $url, $params) = @_;
     $method = uc $method;
+    $params = {%$params};
+    delete $params->{oauth_signature};
+    delete $params->{realm};
     my $normalized_request_url = normalize_request_url($url);
     my $normalized_params = normalize_params($params);
@@ -156 +160 @@
 sub normalize_params {
     my $params = shift;
-    join('&', sort { $a cmp $b }
-        map(sprintf(q{%s=%s}, encode_param($_), encode_param($params->{$_})),
-        grep { $_ ne 'realm' && $_ ne 'oauth_signature' } keys %$params));
+    my @pairs = ();
+    for my $k (keys %$params) {
+        if (!ref $params->{$k}) {
+            push @pairs, 
+                sprintf(q{%s=%s}, encode_param($k), encode_param($params->{$k}));
+        }
+        elsif (ref $params->{$k} eq 'ARRAY') {
+            for my $v (@{ $params->{$k} }) {
+                push @pairs, 
+                    sprintf(q{%s=%s}, encode_param($k), encode_param($v));
+            }
+        }
+    }
+    return join('&', sort { $a cmp $b } @pairs);
 }
 
@@ -209 +224 @@
     my $authorization_header = join(', ', $head,
         sort { $a cmp $b } map(sprintf(q{%s="%s"}, encode_param($_), encode_param($params->{$_})),
-            grep { /^oauth_/ || /^xoauth_/ } keys %$params));
+            grep { /^x?oauth_/ } keys %$params));
     $authorization_header;
 }

lang/perl/OAuth-Lite/trunk/t/01_util.t

@@ -1 @@
-use Test::More tests => 16;
+use Test::More tests => 18;
 
 use OAuth::Lite::Util;
@@ -52 +52 @@
 is($parsed->{oauth_version},          '1.0');
 
+my $params_include_array = {
+        oauth_consumer_key     => 'dpf43f3p214k3103',
+        oauth_token            => 'nnch734d00s12jdk',
+        oauth_signature_method => 'HMAC-SHA1',
+        oauth_timestamp        => '1191242096',
+        oauth_nonce            => 'kllo9940pd9333jh',
+        oauth_version          => '1.0',
+        file                   => 'vacation.jpg',
+        size                   => 'original',
+    selected               => [ 1, 2, 3 ],
+};
 
+my $base2 = OAuth::Lite::Util::create_signature_base_string($http_method, $request_url, $params_include_array);
+is($base2, q{GET&http%3A%2F%2Fphotos.example.net%2Fphotos&file%3Dvacation.jpg%26oauth_consumer_key%3Ddpf43f3p214k3103%26oauth_nonce%3Dkllo9940pd9333jh%26oauth_signature_method%3DHMAC-SHA1%26oauth_timestamp%3D1191242096%26oauth_token%3Dnnch734d00s12jdk%26oauth_version%3D1.0%26selected%3D1%26selected%3D2%26selected%3D3%26size%3Doriginal});
+
+my $params_include_invalidtype = {
+        oauth_consumer_key     => 'dpf43f3p214k3103',
+        oauth_token            => 'nnch734d00s12jdk',
+        oauth_signature_method => 'HMAC-SHA1',
+        oauth_timestamp        => '1191242096',
+        oauth_nonce            => 'kllo9940pd9333jh',
+        oauth_version          => '1.0',
+        file                   => 'vacation.jpg',
+        size                   => 'original',
+    selected               => { unknown => 'type' },
+};
+
+my $base3 = OAuth::Lite::Util::create_signature_base_string($http_method, $request_url, $params_include_invalidtype);
+# throughed unknown type
+is($base3, q{GET&http%3A%2F%2Fphotos.example.net%2Fphotos&file%3Dvacation.jpg%26oauth_consumer_key%3Ddpf43f3p214k3103%26oauth_nonce%3Dkllo9940pd9333jh%26oauth_signature_method%3DHMAC-SHA1%26oauth_timestamp%3D1191242096%26oauth_token%3Dnnch734d00s12jdk%26oauth_version%3D1.0%26size%3Doriginal});
+