Changeset 21800 for lang/perl/LWP-UserAgent-ProgressBar/trunk

Timestamp:

10/21/08 21:54:59 (5 years ago)

Author:

ktat

Message:

add post_with_progress_method for POST request

Location:

lang/perl/LWP-UserAgent-ProgressBar/trunk

Files:

• Changes (modified) (1 diff)
• lib/LWP/UserAgent/ProgressBar.pm (modified) (4 diffs)
• t/01_misc.t (modified) (2 diffs)

lang/perl/LWP-UserAgent-ProgressBar/trunk/Changes

@@ -1 +1 @@
 Revision history for Perl extension LWP-UserAgent-ProgressBar
+
+0.04  Thu Oct 21 21:36:48 JST 2008 (Ktat <ktat at cpan.org>)
+     - add post_with_progress method for POST request. 
 
 0.03  Thu Jul 25 15:27:43 CEST 2008 (Marcel Gruenauer <marcel@cpan.org>)

lang/perl/LWP-UserAgent-ProgressBar/trunk/lib/LWP/UserAgent/ProgressBar.pm

@@ -9 +9 @@
 
 
-our $VERSION = '0.03';
+our $VERSION = '0.04';
 
+sub post_with_progress {
+    my ($self, $url, $form, %args) = @_;
+    $self->_request_with_progress('post', $url, $form, %args);
+}
 
 sub get_with_progress {
     my ($self, $url, %args) = @_;
+    $self->_request_with_progress('get', $url, undef, %args);
+}
+
+sub _request_with_progress {
+    my ($self, $req, $url, $form, %args) = @_;
 
     # don't buffer the prints to make the status update
@@ -38 +47 @@
 
     delete $args{$_} for qw(:content_cb :read_size_hint);
+    $args{':content_cb'} =  sub {
+        my ($data, $cb_response, $protocol) = @_;
 
-    my $response = $self->get(
-        $url,
-        %args,
-        ':content_cb' => sub {
-            my ($data, $cb_response, $protocol) = @_;
+        unless ($did_set_target) {
+            if (my $content_length = $cb_response->content_length) {
+                $progress->target($content_length);
+                $did_set_target = 1;
+            } else {
+                $progress->target($received_size + 2 * length $data);
+            }
+        }
 
-            unless ($did_set_target) {
-                if (my $content_length = $cb_response->content_length) {
-                    $progress->target($content_length);
-                    $did_set_target = 1;
-                } else {
-                    $progress->target($received_size + 2 * length $data);
-                }
-            }
+        $received_size += length $data;
+        $content .= $data;
 
-            $received_size += length $data;
-            $content .= $data;
+        $next_update = $progress->update($received_size) if
+            $received_size >= $next_update;
 
-            $next_update = $progress->update($received_size) if
-                $received_size >= $next_update;
+    };
+    $args{':read_size_hint'} = 8192;
 
-        },
-        ':read_size_hint' => 8192,
-    );
+    my $response = $self->$req($url, $req eq 'get' ? (%$form, %args) : ($form, %args));
+
     print "\n";
     $response->content($content);
@@ -100 +107 @@
 
 Takes the same arguments as L<LWP::UserAgent>'s C<get()>, but overrides the
+C<:content_cb> and C<:read_size_hint> arguments. During download, a progress
+bar is displayed.
+
+=item post_with_progress
+
+Takes the same arguments as L<LWP::UserAgent>'s C<post()>, but overrides the
 C<:content_cb> and C<:read_size_hint> arguments. During download, a progress
 bar is displayed.
@@ -143 +156 @@
 
 Marcel GrE<uuml>nauer, C<< <marcel@cpan.org> >>
+Ktat C<< ktat at cpan.org >>
 
 =head1 COPYRIGHT AND LICENSE

lang/perl/LWP-UserAgent-ProgressBar/trunk/t/01_misc.t

@@ -6 +6 @@
 use File::Spec;
 use LWP::UserAgent::ProgressBar;
-use Test::More tests => 2;
+use Test::More tests => 4;
 use Test::Differences;
 
@@ -25 +25 @@
 eq_or_diff $content, $self_content, 'content matches';
 
+$self_url = 'http://search.cpan.org/search';
+$response = LWP::UserAgent::ProgressBar->new->post_with_progress(
+    $self_url, {query => 'LWP'}, bar_name => '# '
+);
+
+ok($response->is_success, 'successful download');
+ok($response->content, 'content is not empty');
+