Changeset 25581 for lang/perl/Shika/trunk/lib/Shika.pm

Timestamp:

12/01/08 17:19:35 (4 years ago)

Author:

tokuhirom

Message:

performance tuning

Files:

• lang/perl/Shika/trunk/lib/Shika.pm (modified) (1 diff)

lang/perl/Shika/trunk/lib/Shika.pm

@@ -63 +63 @@
         next unless $klass->can('meta');
         my %has_map = %{ $klass->meta->{has} };
-        # set default values
         while (my ($name, $has) = each %has_map) {
-            next if     exists $args->{$name};
-            next unless exists $has->{default} && $has->{default};
-            next if     exists $has->{lazy} && $has->{lazy};
-            next if     exists $has->{lazy_build} && $has->{lazy_build};
-            my $code = $has->{default};
-            $args->{$name} = ref($code) eq 'CODE' ? $code->() : $code;
-        }
-        # process coerce
-        while (my ($name, $has) = each %has_map) {
-            next unless exists $args->{$name};
-            next unless exists $has->{coerce} && $has->{coerce};
-            Carp::confess "does not pass the type constraint because: Validation failed for '$has->{isa}' failed $name"
-                unless Shika::Util::TypeConstraints::check_valid($class, $has, undef, $args->{$name});
-        }
-        # process 'required'
-        while (my ($name, $has) = each %has_map) {
-            next if     exists $args->{$name};
-            next unless $has->{required};
-            Carp::croak "missing parameter $name for $class";
+            # set default values
+            if (
+                (! (exists $args->{$name}))                           &&
+                   (exists $has->{default}    && $has->{default}   )  &&
+                (! (exists $has->{lazy}       && $has->{lazy}      )) &&
+                (! (exists $has->{lazy_build} && $has->{lazy_build}))
+            ) {
+                my $code = $has->{default};
+                $args->{$name} = ref($code) eq 'CODE' ? $code->() : $code;
+            }
+
+            # process coerce
+            if ( $args->{$name} && exists $has->{coerce} && $has->{coerce} ) {
+                Carp::confess "does not pass the type constraint because: Validation failed for '$has->{isa}' failed $name"
+                    unless Shika::Util::TypeConstraints::check_valid($class, $has, undef, $args->{$name});
+            }
+
+            # process 'required'
+            if (!$args->{$name} && $has->{required}) {
+                Carp::croak "missing parameter $name for $class";
+            }
         }
     }