Changeset 25679

Timestamp:

12/02/08 15:24:35 (5 weeks ago)

Author:

miyagawa

Message:

do not warn because it clobbers my console :)

Location:

lang/perl/XML-RSS-LibXML/trunk

Files:

• lib/XML/RSS/LibXML/V2_0.pm (modified) (2 diffs)
• t/regress-broken-image.t (modified) (1 diff)

lang/perl/XML-RSS-LibXML/trunk/lib/XML/RSS/LibXML/V2_0.pm

@@ -156 +156 @@
         if (my $skip = delete $h{$field}) {
             if (ref $skip ne 'HASH') {
-                warn "field $field has invalid entry (does this RSS validate?)";
+#                warn "field $field has invalid entry (does this RSS validate?)";
             } elsif (! UNIVERSAL::isa($skip, 'XML::RSS::LibXML::ElementSpec')) {
                 $c->$field(UNIVERSAL::isa($skip, 'XML::RSS::LibXML::MagicElement') ? $skip : %$skip);
@@ -166 +166 @@
         if (my $v = $h{$field}) {
             if (ref $v ne 'HASH') {
-                warn "field $field has invalid entry (does this RSS validate?)";
+#                warn "field $field has invalid entry (does this RSS validate?)";
             } elsif (! UNIVERSAL::isa($v, 'XML::RSS::LibXML::ElementSpec')) {
                 $c->$field(UNIVERSAL::isa($v, 'XML::RSS::LibXML::MagicElement') ? $v : %$v);

lang/perl/XML-RSS-LibXML/trunk/t/regress-broken-image.t

@@ -32 +32 @@
 {
     my $rss = XML::RSS::LibXML->new;
-    lives_and { 
-        warning_like {
-            $rss->parse($xml)
-        } qr/field image has invalid entry \(does this RSS validate\?\)/;
+    lives_ok { 
+        $rss->parse($xml)
     } 'parse generates warning';
 
     ok( ! $rss->{item}->[0]->{image} );
 }
-
-