Changeset 26904

Timestamp:

12/17/08 01:29:04 (4 years ago)

Author:

drry

Message:

• fixed regexes.
  
• et cetera.
  

Files:

• lang/ruby/robot-twitter/trunk/robot-twitter.rb (modified) (5 diffs)

lang/ruby/robot-twitter/trunk/robot-twitter.rb

@@ -14 +14 @@
 require 'gmail'
 
-$last_statuses = ""
+$last_statuses = ''
 load 'last_statuses.rb'
 
@@ -25 +25 @@
 page = agent.submit(form, form.buttons.first)
 
-mail = ""
+mail = ''
 is_first = true
-statuses = ""
+statuses = ''
 
 for i in 1..30
-  puts "scraping ... Page " + i.to_s + "\n"
-  page = agent.get('http://twitter.com/home/?page=' + i.to_s)
+  puts "scraping ... Page #{i}\n"
+  page = agent.get("http://twitter.com/home/?page=#{i}")
   page.body = page.body.toutf8
 
@@ -38 +38 @@
     content = CGI.unescapeHTML(entry.search('span.entry-content').first.inner_html).gsub(/^\s+/, '')
 
-    # リンクは ... で省略されるので url に置き換える
-    content = content.gsub(%r{<a\s+href="([^"]*?)"\s+rel="[^"]*?"[^>]*?>.*?</a>}m, '\1')
+    # リンクは ... で省略されるので URL に置き換える
+    content = content.gsub(%r{<a\s+href="([^"]*)"\s+rel="[^"]*"[^>]*>.*?</a>}m, '\1')
 
     # 文字オーバーのリンクは削除する
-    content = content.gsub(%r{<a\s+href="[^"]*?"[^>]*?>\.+</a>}m, '')
+    content = content.gsub(%r{<a\s+href="[^"]*"[^>]*>\.+</a>}m, '')
 
     # @username のリンクを外す
-    content = content.gsub(%r{<a\s+href="[^"]*?"[^>]*?>(.*?)</a>}m, '\1')
+    content = content.gsub(%r{<a\s+href="[^"]*"[^>]*>(.*?)</a>}m, '\1')
 
     meta = entry.search('a[@class="entry-date"]').first
     time = meta.search('span.published').first.inner_text
-    statuses = meta["href"]
+    statuses = meta['href']
 
-    # 既読になった最新のステータスの url を記録する
+    # 既読になった最新のステータスの URL を記録する
     if is_first
-      File.open("last_statuses.rb", "wb") {|file| file.write('$lastStatuses = "' + statuses + '"' + "\n")}
+      File.open('last_statuses.rb', 'wb') {|file| file.write(%{$lastStatuses = "#{statuses}"\n})}
       is_first = false
     end
@@ -62 +62 @@
 
     # 逆順に追加する
-    stat = "-----------------------------------------\n"
-    stat += name + "\n\n"
-    stat += content + "\n"
-    stat += time + "\n"
+    stat =  "-----------------------------------------\n"
+    stat << "#{name}\n\n"
+    stat << "#{content}\n"
+    stat << "#{time}\n"
     mail = stat + mail
   end
 
-  if mail == ""
-    puts "** ERROR ** incorrect account or passowrd, otherwise robot-twitter does not work on updated twitter.com" 
+  if mail == ''
+    puts '** ERROR ** incorrect account or passowrd, otherwise robot-twitter does not work on updated twitter.com'
     break
   end
@@ -79 +79 @@
 end
 
-if mail != ""
-  Gmail.send(ENV['GMAIL_USERNAME'], ENV['GMAIL_PASSWORD'], ENV['GMAIL_ADDRESS'], ENV['GMAIL_ADDRESS'], "from robot-twitter", mail.tosjis.tojis)
+if mail != ''
+  Gmail.send(ENV['GMAIL_USERNAME'], ENV['GMAIL_PASSWORD'], ENV['GMAIL_ADDRESS'], ENV['GMAIL_ADDRESS'], 'from robot-twitter', mail.tosjis.tojis)
 end