Changeset 294 for lang/perl/WebService-Coneco/trunk/lib/WebService/Coneco.pm

Timestamp:

09/28/07 10:23:33 (16 months ago)

Author:

xcezx

Message:

lang/perl/WebService-Coneco: テストの追加とちょびっとした変更

Files:

• lang/perl/WebService-Coneco/trunk/lib/WebService/Coneco.pm (modified) (5 diffs)

lang/perl/WebService-Coneco/trunk/lib/WebService/Coneco.pm

@@ -3 +3 @@
 use warnings;
 
-our $VERSION = '0.01';
+our $VERSION = '0.02';
 
 use Carp;
 use URI;
 use LWP::UserAgent;
+
 use XML::Simple;
 eval { require XML::Parser };
@@ -23 +24 @@
 
   my $coneco = WebService::Coneco->new( api_key => 'Your API Key');
-  my $res = $coneco->call( 'ConecoMethodName', { arg1 => 'arg1', arg2 => 'arg2', } )
-    or die $coneco->errstr;
 
 =head1 DESCRIPTION
@@ -51 +50 @@
 }
 
-=head2 call( $method, [\%method_options, \%parser_options] )
+=head2 call( 'MethodName', \%options )
 
 =cut
 
 sub call {
-    my ( $self, $method, $method_options, $parser_options ) = @_;
-    croak $self->{errstr} = qq/Method required./ unless $method;
+    my ( $self, $method_name, $method_options, $parser_options ) = @_;
+    croak qq/Method name is required./ unless $method_name;
 
-    my $query = { apikey => $self->{api_key}, };
-    while ( my ( $key, $value ) = each %$method_options ) {
-        $query->{$key} = $value;
-    }
+    my $uri = URI->new( $APIBase . $method_name );
+    $uri->query_form(
+        apikey => $self->{api_key},
+        %$method_options,
+    );
 
-    $self->{uri} = URI->new( $APIBase . $method );
-    $self->{uri}->query_form($query);
-
-    my $res = $self->{ua}->request( HTTP::Request->new( GET => $self->{uri} ) );
+    my $res = $self->{ua}->request( HTTP::Request->new( GET => $uri ) );
 
     $self->parse( $res, $parser_options );
@@ -89 +86 @@
     $data->{Header} = $parser->XMLin( $res->content )->{Header};
     if ( $data->{Header}->{Status} ne 'Success' ) {
-        $self->{errstr} =
-          qq/Response error: $data->{Header}->{Status}: $data->{Header}->{Detail}/;
+        $self->{errstr} = qq/Response error: $data->{Header}->{Status}: $data->{Header}->{Detail}/;
         return;
     }
@@ -103 +99 @@
 sub errstr {
     my $self = shift;
-
     $self->{errstr};
 }