Changeset 29869

Timestamp:

02/10/09 23:19:08 (4 years ago)

Author:

nekokak

Message:

remove Accessor.

Location:

lang/perl/DBIx-Skinny/trunk

Files:

• lib/DBIx/Skinny/Row.pm (modified) (9 diffs)
• tools/benchmark.pl (modified) (1 diff)

lang/perl/DBIx-Skinny/trunk/lib/DBIx/Skinny/Row.pm

@@ -2 +2 @@
 use strict;
 use warnings;
-use DBIx::Skinny::Accessor;
 use Carp;
 
-mk_accessors(qw/ row_data skinny select_columns opt_table_info get_column_cache /);
-
-sub init {
-    my $self = shift;
-    $self->select_columns([keys %{$self->row_data}]);
+sub new {
+    my ($class, $args) = @_;
+    my $self = bless {%$args}, $class;
+    $self->{select_columns} = [keys %{$self->{row_data}}];
+    return $self;
 }
 
@@ -16 +15 @@
     my $class = ref $self;
 
-    for my $alias ( @{$self->select_columns} ) {
+    for my $alias ( @{$self->{select_columns}} ) {
         (my $col = lc $alias) =~ s/.+\.(.+)/$1/o;
         next if $class->can($col);
@@ -23 +22 @@
     }
 
-    $self->{get_column_cache} = {};
+    $self->{get_column_cached} = {};
 }
 
@@ -32 +31 @@
         my $self = shift;
 
-        unless ( $self->{get_column_cache}->{$col} ) {
+        unless ( $self->{get_column_cached}->{$col} ) {
           my $data = $self->get_column($col);
-          $self->{get_column_cache}->{$col} = $self->skinny->schema->call_inflate($col, $data);
+          $self->{get_column_cached}->{$col} = $self->{skinny}->schema->call_inflate($col, $data);
         }
-        $self->{get_column_cache}->{$col};
+        $self->{get_column_cached}->{$col};
     };
 }
@@ -43 +42 @@
     my ($self, $col) = @_;
 
-    my $data = $self->row_data->{$col};
+    my $data = $self->{row_data}->{$col};
 
-    $data = $self->skinny->schema->utf8_on($col, $data);
+    $data = $self->{skinny}->schema->utf8_on($col, $data);
 
     return $data;
@@ -54 +53 @@
 
     my %data;
-    for my $col ( @{$self->select_columns} ) {
+    for my $col ( @{$self->{select_columns}} ) {
         $data{$col} = $self->get_column($col);
     }
@@ -62 +61 @@
 sub insert {
     my $self = shift;
-    $self->skinny->find_or_create($self->opt_table_info, $self->get_columns);
+    $self->{skinny}->find_or_create($self->{opt_table_info}, $self->get_columns);
 }
 
 sub update {
     my ($self, $args, $table) = @_;
-    $table ||= $self->opt_table_info;
+    $table ||= $self->{opt_table_info};
     my $where = $self->_update_or_delete_cond($table);
-    $self->skinny->update($table, $args, $where);
+    $self->{skinny}->update($table, $args, $where);
 }
 
 sub delete {
     my ($self, $table) = @_;
-    $table ||= $self->opt_table_info;
+    $table ||= $self->{opt_table_info};
     my $where = $self->_update_or_delete_cond($table);
-    $self->skinny->delete($table, $where);
+    $self->{skinny}->delete($table, $where);
 }
 
@@ -86 +85 @@
     }
 
-    my $schema_info = $self->skinny->schema->schema_info;
+    my $schema_info = $self->{skinny}->schema->schema_info;
     unless ( $schema_info->{$table} ) {
         croak "unknown table: $table";
@@ -97 +96 @@
     }
 
-    unless (grep { $pk eq $_ } @{$self->select_columns}) {
+    unless (grep { $pk eq $_ } @{$self->{select_columns}}) {
         croak "can't get primary column in your query.";
     }

lang/perl/DBIx-Skinny/trunk/tools/benchmark.pl

@@ -37 +37 @@
 2009-02-10 23:10
  2 wallclock secs ( 2.16 usr +  0.00 sys =  2.16 CPU) @ 33.80/s (n=73)
+2009-02-10 23:16
+ 2 wallclock secs ( 2.11 usr +  0.00 sys =  2.11 CPU) @ 39.34/s (n=83)