Changeset 3099 for platform/quicksilver/TwitterPlugin

Timestamp:

12/13/07 01:49:01 (13 months ago)

Author:

mootoh

Message:

platform/quicksilver/TwitterPlugin: fix possible leak, add a screenshot.

Location:

platform/quicksilver/TwitterPlugin

Files:

• Info.plist (modified) (1 diff)
• Screenshot-1.png (added)
• TwitterPluginAction.m (modified) (4 diffs)

platform/quicksilver/TwitterPlugin/Info.plist

@@ -16 +16 @@
         <string>BNDL</string>
         <key>CFBundleVersion</key>
-        <string>4F</string>
+        <string>60</string>
         <key>NSPrincipalClass</key>
         <string>TwitterPlugin</string>

platform/quicksilver/TwitterPlugin/TwitterPluginAction.m

@@ -16 +16 @@
   // construct request body
   NSString *content = [NSString stringWithFormat:@"status=%@", [dObject stringValue]];
-  NSLog(content);
+  //NSLog(content);
   [content stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
 
@@ -23 +23 @@
   NSString *screenName = [values valueForKey:@"TwitterPreference.screenName"];
   NSString *password   = [values valueForKey:@"TwitterPreference.password"];
-  NSLog(@"screenName:%@, password:%@", screenName, password);
+  //NSLog(@"screenName:%@, password:%@", screenName, password);
 
   // construct request
@@ -40 +40 @@
     receivedData = [[NSMutableData data] retain];
   } else {
-    NSLog(@"not connected correctly.");
+    //NSLog(@"not connected correctly.");
   }
 
@@ -61 +61 @@
  - (void) connection : (NSURLConnection *) connection 
         didFailWithError : (NSError *) error {
-        NSLog(@"didFailWithError 1");
+        //NSLog(@"didFailWithError 1");
         // [connection release];
-        // [receivedData release];
-        
-        NSLog(@"didFailWithError 2");
+        [receivedData release]; 
+        //NSLog(@"didFailWithError 2");
 }
 
 - (void) connectionDidFinishLoading:(NSURLConnection *)connection {
-        NSLog(@"connectionDidFinishLoading: succeeded to load %d bytes", [receivedData length]);
-        [(NSData *)receivedData writeToFile:@"/tmp/connectionDidFinishLoading.log"
-                atomically:YES];
+//      NSLog(@"connectionDidFinishLoading: succeeded to load %d bytes", [receivedData length]);
 //      [connection release];
-//      [receivedData release];
+        [receivedData release];
 }
 @end