Changeset 32492 for lang/perl/Data-Model

Timestamp:

04/16/09 19:13:01 (4 years ago)

Author:

yappo

Message:

unique index query support for find_or_create

Location:

lang/perl/Data-Model/trunk

Files:

• lib/Data/Model/Mixin/FindOrCreate.pm (modified) (3 diffs)
• t/050_mixin/find_or_create.t (modified) (5 diffs)

lang/perl/Data-Model/trunk/lib/Data/Model/Mixin/FindOrCreate.pm

@@ -2 +2 @@
 use strict;
 use warnings;
+
+use Carp ();
 
 sub register_method {
@@ -11 +13 @@
 sub find_or_create {
     my($self, $model, $key, $columns) = @_;
-    my $row = $self->lookup( $model => $key );
-    return $row if $row;
+    my $row;
+    if (ref($key) eq 'HASH') {
+        # use on unique index
+        my($index, $value) = %{ $key };
+        Carp::corak('index name is required') unless $index;
 
-    $self->set( $model => $key => $columns );
+        my $schema = $self->get_schema($model);
+        Carp::croak("'$index' is not unique index") unless $schema->unique->{$index};
+
+        ($row) = $self->get($model, { index => { $index => $value } });
+        return $row if $row;
+        $self->set( $model => $columns );
+    } else {
+        # primary key
+
+        $row = $self->lookup( $model => $key );
+        return $row if $row;
+        $self->set( $model => $key => $columns );
+    }
+
 }
 
@@ -41 +59 @@
   );
 
+  # using unique index, but not use normal index
+  $model->find_or_create(
+      tablename => { unique_idx => 'key' } => {
+          field1 => 'value',
+          field2 => 'value',
+      }
+  );
+
+  $model->find_or_create(
+      tablename => { unique_idx => [qw/ key1 key2 /] } => {
+          field1 => 'value',
+          field2 => 'value',
+      }
+  );
+
 =cut
 

lang/perl/Data-Model/trunk/t/050_mixin/find_or_create.t

@@ -1 +1 @@
 use t::Utils;
-use Test::More tests => 53;
+use Test::More tests => 107;
 
 my $dsn = 'dbi:SQLite:dbname=' . temp_filename;
@@ -25 +25 @@
         columns qw/id1 id2 data/;
     };
+
+    install_model test3 => schema {
+        unique single_unique => 'id';
+        columns qw/id data/;
+    };
+
+    install_model test4 => schema {
+        unique multi_unique => [qw/ id1 id2 /];
+        columns qw/id1 id2 data/;
+    };
+
+    install_model test5 => schema {
+        index single_index => 'id';
+        columns qw/id data/;
+    };
 }
 
@@ -30 +45 @@
 setup_schema( $dsn => $model->as_sqls );
 
+# single primary key
 do {
     my $set = $model->find_or_create(
@@ -87 +103 @@
 };
 
+# multi primary key
 do {
     my $set = $model->find_or_create(
@@ -150 +167 @@
 };
 
+# single unique
+do {
+    my $set = $model->find_or_create(
+        test3 => { single_unique => 'key1' } => {
+            id   => 'key1',
+            data => 'data1',
+        }
+    );
+    isa_ok($set, 'TestModel::test3');
+    is($set->id, 'key1', 'id');
+    is($set->data, 'data1', 'data');
+
+    my $get = $model->find_or_create(
+        test3 => { single_unique => 'key1' } => {
+            id   => 'key1',
+            data => 'data1',
+        }
+    );
+    isa_ok($get, 'TestModel::test3');
+    is($get->id, 'key1', 'id');
+    is($get->data, 'data1', 'data');
+
+    my @rows = $model->get( 'test3' );
+    is(scalar(@rows), 1, '1 record');
+
+    isa_ok($rows[0], 'TestModel::test3');
+    is($rows[0]->id, 'key1', 'id');
+    is($rows[0]->data, 'data1', 'data');
+
+
+    my $set2 = $model->find_or_create(
+        test3 => { single_unique => 'key2' } => {
+            id   => 'key2',
+            data => 'data2',
+        }
+    );
+    isa_ok($set2, 'TestModel::test3');
+    is($set2->id, 'key2', 'id');
+    is($set2->data, 'data2', 'data');
+
+    my $get2 = $model->find_or_create(
+        test3 => { single_unique => 'key2' } => {
+            id   => 'key2',
+            data => 'data2',
+        }
+    );
+    isa_ok($get2, 'TestModel::test3');
+    is($get2->id, 'key2', 'id');
+    is($get2->data, 'data2', 'data');
+
+    @rows = $model->get( 'test3' );
+    is(scalar(@rows), 2, '2 record');
+
+    isa_ok($rows[0], 'TestModel::test3');
+    is($rows[0]->id, 'key1', 'id');
+    is($rows[0]->data, 'data1', 'data');
+
+    isa_ok($rows[1], 'TestModel::test3');
+    is($rows[1]->id, 'key2', 'id');
+    is($rows[1]->data, 'data2', 'data');
+};
+
+# multi primary key
+do {
+    my $set = $model->find_or_create(
+        test4 => { multi_unique => [qw/ key10 key20 /] } => {
+            id1  => 'key10',
+            id2  => 'key20',
+            data => 'data1',
+        }
+    );
+    isa_ok($set, 'TestModel::test4');
+    is($set->id1, 'key10', 'id1');
+    is($set->id2, 'key20', 'id2');
+    is($set->data, 'data1', 'data');
+
+    my $get = $model->find_or_create(
+        test4 => { multi_unique => [qw/ key10 key20 /] } => {
+            id1  => 'key10',
+            id2  => 'key20',
+            data => 'data1',
+        }
+    );
+    isa_ok($get, 'TestModel::test4');
+    is($get->id1, 'key10', 'id1');
+    is($get->id2, 'key20', 'id2');
+    is($get->data, 'data1', 'data');
+
+    my @rows = $model->get( 'test4' );
+    is(scalar(@rows), 1, '1 record');
+
+    isa_ok($rows[0], 'TestModel::test4');
+    is($rows[0]->id1, 'key10', 'id1');
+    is($rows[0]->id2, 'key20', 'id2');
+    is($rows[0]->data, 'data1', 'data');
+
+    my $set2 = $model->find_or_create(
+        test4 => { multi_unique => [qw/ key11 key21 /] } => {
+            id1  => 'key11',
+            id2  => 'key21',
+            data => 'data2',
+        }
+    );
+    isa_ok($set2, 'TestModel::test4');
+    is($set2->id1, 'key11', 'id1');
+    is($set2->id2, 'key21', 'id2');
+    is($set2->data, 'data2', 'data');
+
+    my $get2 = $model->find_or_create(
+        test4 => { multi_unique => [qw/ key11 key21 /] } => {
+            id1  => 'key11',
+            id2  => 'key21',
+            data => 'data2',
+        }
+    );
+    isa_ok($get2, 'TestModel::test4');
+    is($get2->id1, 'key11', 'id1');
+    is($get2->id2, 'key21', 'id2');
+    is($get2->data, 'data2', 'data');
+
+    @rows = $model->get( 'test4' );
+    is(scalar(@rows), 2, '1 record');
+
+    isa_ok($rows[0], 'TestModel::test4');
+    is($rows[0]->id1, 'key10', 'id1');
+    is($rows[0]->id2, 'key20', 'id2');
+    is($rows[0]->data, 'data1', 'data');
+
+    isa_ok($rows[1], 'TestModel::test4');
+    is($rows[1]->id1, 'key11', 'id1');
+    is($rows[1]->id2, 'key21', 'id2');
+    is($rows[1]->data, 'data2', 'data');
+};
+
+# index is error
+do {
+    eval {
+        $model->find_or_create(
+            test5 => { single_index => 'key1' } => {
+                data => 'data1',
+            }
+        );
+    };
+    like($@, qr/'single_index' is not unique index/, 'not use normal index');
+};
+