Changeset 33054

Timestamp:

05/04/09 22:54:05 (4 years ago)

Author:

rikeda

Message:

リファクタリング。

Files:

• lang/java/misc/ssh-blank/src/main/java/org/coderepos/action/EmpAction.java (modified) (1 diff)

lang/java/misc/ssh-blank/src/main/java/org/coderepos/action/EmpAction.java

@@ -30 +30 @@
                         HttpServletRequest request, HttpServletResponse response)
                         throws Exception {
-                String id = request.getParameter("id");
+                Integer id = toInteger(request.getParameter("id"), 1);
 
-                Integer theId;
-                try {
-                        theId = Integer.valueOf(Integer.parseInt(id));
-                } catch (NumberFormatException ignore) {
-                        theId = Integer.valueOf(1);
-                }
-
-                Emp emp = empService.findById(theId);
+                Emp emp = empService.findById(id);
                 request.setAttribute("emp", emp);
 
                 return mapping.findForward("success");
+        }
+
+        private static Integer toInteger(String str, int defaultInt) {
+                Integer i;
+                try {
+                        i = Integer.valueOf(Integer.parseInt(str));
+                } catch (NumberFormatException ignore) {
+                        i = Integer.valueOf(defaultInt);
+                }
+                return i;
         }