Changeset 33209 for platform/firefox/FireMobileSimulator/branches/1.1.X

Timestamp:

05/10/09 13:04:47 (4 years ago)

Author:

thorikawa

Message:

fix #158,#159

Location:

platform/firefox/FireMobileSimulator/branches/1.1.X/src

Files:

• chrome/content/about.xul (modified) (1 diff)
• chrome/content/common/carrier.js (modified) (1 diff)
• chrome/content/contentHandler.js (modified) (1 diff)
• chrome/content/options/dialogs/device.js (modified) (2 diffs)
• install.rdf (modified) (2 diffs)

platform/firefox/FireMobileSimulator/branches/1.1.X/src/chrome/content/about.xul

@@ -28 +28 @@
 <vbox>
   <label value="FireMobileSimulator" style="font-weight: bold; font-size: x-large;"/>
-  <label value="&version; 1.1.3"/>
+  <label value="&version; 1.1.4"/>
   <separator class="thin"/>
   <label value="&createdBy;" style="font-weight: bold;"/>

platform/firefox/FireMobileSimulator/branches/1.1.X/src/chrome/content/common/carrier.js

@@ -121 +121 @@
 firemobilesimulator.common.carrier.getDoCoMoUserAgent = function(useragent, id) {
         var type1 = parent.firemobilesimulator.common.pref.copyUnicharPref("msim.devicelist."+id+".type1");
-        var cache = parent.firemobilesimulator.common.pref.copyUnicharPref("msim.devicelist."+id+".cache");
+        var cache = parent.firemobilesimulator.common.pref.copyUnicharPref("msim.devicelist."+id+".cache") || 100;
         if (firemobilesimulator.common.carrier.Type[firemobilesimulator.common.carrier.DOCOMO].DOCOMO_FOMA == type1) {
                 //TODO ;TB;WxxHxxの部分も動的に組み立てられるようにする

platform/firefox/FireMobileSimulator/branches/1.1.X/src/chrome/content/contentHandler.js

@@ -28 +28 @@
 firemobilesimulator.contentHandler.factoryMap[firemobilesimulator.common.carrier.AU] = firemobilesimulator.contentHandler.au;
 firemobilesimulator.contentHandler.factoryMap[firemobilesimulator.common.carrier.SOFTBANK] = firemobilesimulator.contentHandler.softbank;
+firemobilesimulator.contentHandler.factoryMap[firemobilesimulator.common.carrier.OTHER] = firemobilesimulator.contentHandler.common;
 
 firemobilesimulator.contentHandler.factory = function (carrier) {

platform/firefox/FireMobileSimulator/branches/1.1.X/src/chrome/content/options/dialogs/device.js

@@ -106 +106 @@
                 var carrier = firemobilesimulator.options.dialogs.device.carrier;
 
+                var deviceName = document.getElementById("msim.options.device.label").value;
+                var userAgent = document.getElementById("msim.options.device.useragent").value;
+                var si = document.getElementById("msim.options.device.type.menulist").selectedItem;
+                var type1 = si ? si.getAttribute("label") : null;
+                var screenWidth = document.getElementById("msim.options.device.screen-width").value;
+                var screenHeight = document.getElementById("msim.options.device.screen-height").value;
+
+                // 入力チェック
+                if (!deviceName || !carrier || !userAgent) {
+                        dump("[msim]Warning : Required field is null.\n");
+                        alert(firemobilesimulator.options.dialogs.device.stringBundle
+                                        .getString("msim_editDeviceRequirementValidation"));
+                        return false;
+                }
+
                 if (firemobilesimulator.options.dialogs.device.windowType == "add") {
                         // carrier =
@@ -116 +131 @@
                 }
 
-                dump("save-carrier:" + carrier + "\n");
-                dump("save-id:" + saveId + "\n");
-
-                var deviceName = document.getElementById("msim.options.device.label").value;
-                var userAgent = document.getElementById("msim.options.device.useragent").value;
-                var type1 = document.getElementById("msim.options.device.type.menulist").selectedItem.getAttribute("label");
-                var screenWidth = document.getElementById("msim.options.device.screen-width").value;
-                var screenHeight = document.getElementById("msim.options.device.screen-height").value;
-
-                // 入力チェック
-                if (!deviceName || !carrier || !userAgent) {
-                        dump("[msim]Warning : Required field is null.\n");
-                        alert(firemobilesimulator.options.dialogs.device.stringBundle
-                                        .getString("msim_editDeviceRequirementValidation"));
-                        return false;
-                }
+                //dump("save-carrier:" + carrier + "\n");
+                //dump("save-id:" + saveId + "\n");
+
                 firemobilesimulator.common.pref.setUnicharPref("msim.devicelist." + saveId + ".label", deviceName);
                 firemobilesimulator.common.pref.setUnicharPref("msim.devicelist." + saveId + ".carrier", carrier);

platform/firefox/FireMobileSimulator/branches/1.1.X/src/install.rdf

@@ -5 +5 @@
     <em:id>{77cc852e-6b45-11dd-929f-d30256d89593}</em:id>
     <em:name>FireMobileSimulator</em:name>
-    <em:version>1.1.3</em:version>
+    <em:version>1.1.4</em:version>
     <em:creator>Takahiro Horikawa</em:creator>
     <em:aboutURL>chrome://msim/content/about.xul</em:aboutURL>
@@ -13 +13 @@
         <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id> <!-- Firefox -->
         <em:minVersion>2.0</em:minVersion>
-        <em:maxVersion>3.1.*</em:maxVersion>
+        <em:maxVersion>3.5.*</em:maxVersion>
       </Description>
     </em:targetApplication>