Changeset 33468 for lang/perl/WWW-Allcinema

Timestamp:

05/21/09 08:15:53 (4 years ago)

Author:

cento

Message:

write POD and test

Location:

lang/perl/WWW-Allcinema/trunk

Files:

• lib/WWW/Allcinema.pm (modified) (8 diffs)
• t/01_search.t (modified) (4 diffs)
• t/03_process_page.t (modified) (2 diffs)

lang/perl/WWW-Allcinema/trunk/lib/WWW/Allcinema.pm

@@ -4 +4 @@
 use warnings;
 use LWP::UserAgent;
-use HTTP::Request::Common qw(POST);
 use HTML::TokeParser;
 use Encode;
@@ -38 +37 @@
     my $self = shift;
     $self->_get_page() unless $self->error;
-    return $self->{matched};
+    return $self->{_likely};
 }
 
@@ -162 +161 @@
                 if ( $_->{title} =~ /^$title$/ ) {
                     $self->id( $_->{id} );
-                    $self->{matched} = [ { id => $_->{id}, title => $title } ];
-                    last;
+                    $self->{_likely} = { id => $_->{id}, title => $title };
                 }
             }
@@ -169 +167 @@
         unless ( $self->id ) {
             $self->id( $matched->[0]->{id} );
-        }
-        $self->_get_page();
+            $self->{_likely} =
+              { id => $matched->[0]->{id}, title => $matched->[0]->{title} };
+        }
     }
     else {
@@ -290 +289 @@
   use WWW::Allcinema;
   my $ac = WWW::Allcinema->new('ゆれる');
-  print $ac->director; # 西川美和
+  my $result = $ac->search();
+  $ac->get();
+  print $ac->director(); # 西川美和
 
 =head1 DESCRIPTION
@@ -304 +305 @@
 =item new()
 
-Give a film title or allcinema ID. If you give a title, it will search first, and then access to the page of most likely page while it directly goes to the movie information page when given ID.
+Give a film title or allcinema ID or country. If you give a ID, it can directly goes to the movie information page when given ID while it will search first, and then access to the page of most likely page when given other parameters.
 
   my $ac = WWW::Allcinema->new('GOEMON');
 
-or
-
   my $ac = WWW::Allcinema->new({id => 330507});
 
+  my $ac = WWW::Allcinema->new({title=>'大捜査線',country=>'香港'});
+
 =back
 
@@ -318 +319 @@
 =over 4
 
-=item title()
-
-  returns title
-
-=item id()
-
-  returns allcinema ID
-
-=item year()
-
-  returns year
-
-=item time()
-
-  returns time by minute
-
-=item country()
-
-  returns country
-
-=item genre()
-
-  returns genre arrayref
-
-=item director()
-
-  returns director
-
-=item producers()
-
-  returns producers arrayref
-
-=item screenplay()
-
-  returns screenplay arrayref
-
-=item cast()
-
-  returns cast arrayref ([{'cast'=>'role'},...,])
-
-=item error()
-
-returns error message.
-
-  if($ac->error){
-    print "error: $ac->error";
-  }
+=item search()
+
+searches by given constructor parameters and returns most likely result.
+
+  my $result = $ac->search();
+  print "id: $result->{id}, title: $result->{title}";
 
 =item matched()
 
-returns id and title of search result
-
+returns all search results
+
+  $ac->search();
   my $matched = $ac->matched;
   if($matched){
@@ -377 +338 @@
   }
 
+=item title()
+
+returns title
+
+=item id()
+
+returns allcinema ID
+
+=item year()
+
+returns year
+
+=item time()
+
+returns time by minute
+
+=item country()
+
+returns country
+
+=item genre()
+
+returns genre arrayref
+
+=item director()
+
+returns director
+
+=item producers()
+
+returns producers arrayref
+
+=item screenplay()
+
+returns screenplay arrayref
+
+=item cast()
+
+returns cast arrayref ([{'cast'=>'role'},...,])
+
+=item error()
+
+returns error message.
+
+  if($ac->error){
+    print "error: $ac->error";
+  }
+
+
 =back
 

lang/perl/WWW-Allcinema/trunk/t/01_search.t

@@ -10 +10 @@
 my $result = $ac->search();
 is_deeply( $result,
-    [ { id => 51832, title => 'トレインスポッティング' } ],
+    { id => 51832, title => 'トレインスポッティング' },
     'title scalar' );
 
@@ -17 +17 @@
 is_deeply(
     $result,
-    [
-        {
-            id    => 150405,
-            title => '機動戦士ガンダム　逆襲のシャア'
-        }
-    ],
+    {
+        id    => 150405,
+        title => '機動戦士ガンダム　逆襲のシャア',
+    },
     'title hash'
 );
@@ -30 +28 @@
 $result = $ac->search();
 is_deeply(
-    $result->[0],
+    $result,
     { id => 4998, title => 'ガンジー' },
     'title and country'
@@ -38 +36 @@
     { 'country' => [ ( 'スウェーデン', '日本' ) ] } );
 $result = $ac->search();
-is_deeply( $result->[0], { id => 12977, title => '戦争の顔' },
-    'countries' );
+is_deeply( $result, { id => 12977, title => '戦争の顔' }, 'countries' );
 
 $ac     = WWW::Allcinema->new('ゆれる');
 $result = $ac->search();
-is_deeply(
-    $result,
-    [ { id => 324256, title => 'ゆれる' } ],
-    'some candidates'
-);
+is_deeply( $result, { id => 324256, title => 'ゆれる' }, 'some candidates' );
 

lang/perl/WWW-Allcinema/trunk/t/03_process_page.t

@@ -83 +83 @@
 
 $ac = WWW::Allcinema->new('崖の上のポニョ');
+$ac->search();
 $ac->get();
-
 is( $ac->title, '崖の上のポニョ', 'title' );
 is( $ac->year,  2008,                    'year' );
@@ -96 +96 @@
 is_deeply( $ac->music,      [qw(久石譲)],    'music' );
 
-# $ac = WWW::Allcinema->new('ダイハード');
-# $ac->get();
-# is( $ac->title, 'ダイ・ハード', 'more than two candidates not matched' );
-
-# $ac = WWW::Allcinema->new( { id => 766 } );
-# $ac->get();
-# is_deeply(
-#     $ac->country,
-#     [qw(アメリカ ニュージーランド)],
-#     'multi countries'
-# );
+$ac = WWW::Allcinema->new( { id => 766 } );
+$ac->get();
+is_deeply(
+    $ac->country,
+    [qw(アメリカ ニュージーランド)],
+    'multi countries'
+);