Changeset 33682

Timestamp:

05/31/09 09:27:22 (4 years ago)

Author:

snaka

Message:

ログインされていない場合の判定を追加

Files:

• lang/javascript/vimperator-plugins/trunk/pino.js (modified) (5 diffs)

lang/javascript/vimperator-plugins/trunk/pino.js

@@ -42 +42 @@
   <author mail="snaka.gml@gmail.com" homepage="http://vimperator.g.hatena.ne.jp/snaka72/">snaka</author>
   <license>MIT style license</license>
-  <version>1.3.0</version>
+  <version>1.3.1</version>
   <detail><![CDATA[
     == Subject ==
@@ -148 +148 @@
       let pins = new Pins();
       let items = pins.items();
-      if (items.length == 0) {
+      if (!items || items.length == 0) {
         liberator.echo("Pinned item doesn't exists.");
         return;
@@ -226 +226 @@
               ? this.cache
               : this.cache = this._getPinnedItems();
-      return result.sort(this.sortOrder);
+      return (result || []).sort(this.sortOrder);
     },
 
@@ -271 +271 @@
 
       request.addEventListener("onSuccess", function(data) {
-        liberator.log(data);
+        if (isLoginPage(data)) {
+          liberator.echoerr("Can't get pinned list. Maybe you should login to livedoor.");
+          return;
+        }
         result = liberator.eval(data.responseText);
       });
       request.addEventListener("onFailure", function(data) {
         liberator.echoerr("Can't get pinned list!!!");
-        liberator.log(data);
       });
       request.post();
@@ -316 +318 @@
     ].join('&');
 
+  function isLoginPage(response)
+    response.responseText.substr(0, 5) == '<?xml'
+
   // }}}
   // API /////////////////////////////////////////////////////////// {{{