Changeset 33847

Timestamp:

06/08/09 20:09:51 (4 years ago)

Author:

tokuhirom

Message:

support H::Headers::Fast in more better way

Location:

lang/perl/HTTP-MobileAgent/trunk

Files:

• Makefile.PL (modified) (1 diff)
• lib/HTTP/MobileAgent/Request.pm (modified) (2 diffs)
• t/01_request.t (modified) (1 diff)

lang/perl/HTTP-MobileAgent/trunk/Makefile.PL

@@ -5 +5 @@
 requires 'HTTP::Headers' => 1.43;
 requires 'WWW::MobileCarrierJP' => 0.04;
+requires 'Scalar::Util' => 1.14;
 
 build_requires 'Test::More' => 0.32;

lang/perl/HTTP-MobileAgent/trunk/lib/HTTP/MobileAgent/Request.pm

@@ -1 +1 @@
 package HTTP::MobileAgent::Request;
 use strict;
+use Scalar::Util ();
 
 sub new {
@@ -10 +11 @@
         bless { r => $stuff }, 'HTTP::MobileAgent::Request::Apache';
     }
-    elsif (UNIVERSAL::isa($stuff, 'HTTP::Headers') || UNIVERSAL::isa($stuff, 'HTTP::Headers::Fast')) {
+    elsif (Scalar::Util::blessed($stuff) && $stuff->isa('HTTP::Headers')) {
         bless { r => $stuff }, 'HTTP::MobileAgent::Request::HTTPHeaders';
     }

lang/perl/HTTP-MobileAgent/trunk/t/01_request.t

@@ -34 +34 @@
 SKIP: {
     eval { require HTTP::Headers::Fast; };
-    skip "no HTTP::Headers::Fast", 2 if $@;
+    skip "no HTTP::Headers::Fast", 2 if $@ || $HTTP::Headers::Fast::VERSION < 0.10; # 0.11 or later supports ->isa
 
     my $header = HTTP::Headers::Fast->new;