Changeset 35164 for lang/perl

Timestamp:

09/02/09 17:08:23 (4 years ago)

Author:

kazuho

Message:

optimization

Files:

• lang/perl/DBIx-ShardManager-Pacific/trunk/lib/DBIx/ShardManager/Pacific.pm (modified) (2 diffs)

lang/perl/DBIx-ShardManager-Pacific/trunk/lib/DBIx/ShardManager/Pacific.pm

@@ -58 +58 @@
                 && defined $get_match_col->($row);
         my $dbh = $self->rw_handle($get_shard_col->($row));
+        my $match_val = $get_match_col->($row);
         if (my $t = first { $_->[0] == $dbh } @dbh_cols) {
-            push @{$t->[1]}, $get_match_col->($row);
+            if (my $u = $t->[1]->{$match_val}) {
+                push @$u, $row;
+            } else {
+                $t->[1]->{$match_val} = [ $row ];
+            }
         } else {
-            push @dbh_cols, [ $dbh, [ $get_match_col->($row) ] ];
+            push @dbh_cols, [ $dbh, { $match_val => [ $row ] } ];
         }
     }
@@ -70 +75 @@
             $join_tbl,
             $join_col,
-            join(',', map { $dc->[0]->quote($_) } @{$dc->[1]}),
+            join(',', map { $dc->[0]->quote($_) } sort keys %{$dc->[1]}),
         );
-        print STDERR "SQL:$query\n";
-        my %join_rows = map {
-            +($_->{$join_col} => $_),
-        } @{$dc->[0]->selectall_arrayref($query, { Slice => {} })};
-        for my $row (@$rows) {
-            if (defined $get_shard_col->($row)
-                    && defined $get_match_col->($row)
-                        && defined $join_rows{$get_match_col->($row)}) {
-                $set_match_col->($row, $join_rows{$get_match_col->($row)});
+        # print STDERR "SQL:$query\n";
+        for my $join_row (
+            @{$dc->[0]->selectall_arrayref($query, { Slice => {} })}
+        ) {
+            for my $row (@{$dc->[1]->{$join_row->{$join_col}}}) {
+                $set_match_col->($row, $join_row);
             }
         }