Changeset 3519 for lang/javascript/userchrome

Timestamp:

12/24/07 13:32:19 (13 months ago)

Author:

cho45

Message:

lang/javascript/userchrome/editonfavorite.uc.js:

Object での管理から Array での管理に変更 (ハッシュアクセスが必要なくなってた)
監視する必要がなくなったら clearInterval するように

Files:

• lang/javascript/userchrome/editonfavorite.uc.js (modified) (4 diffs)

lang/javascript/userchrome/editonfavorite.uc.js

@@ -32 +32 @@
                 }
 
-                self.watching = {};
+                self.watching = [];
         },
 
@@ -64 +64 @@
                         args.unshift("-a", "Vim");
                         ps.run(false, args, args.length);
-                        self.watching[file.path] = {
+                        self.watching.push({
                                 file: file,
                                 time: (new Date()).getTime(),
                                 doc: e.target.ownerDocument,
                                 target: e.target
-                        };
+                        });
                         if (!self.watcher) {
                                 self.watcher = setInterval(function () {
                                         self.watch();
                                 }, 1000);
+                                log("start watcher thread. "+self.watcher);
                         }
                 }
@@ -81 +82 @@
                 log("unload"+e.originalTarget);
                 var self = this;
-                for (var k in self.watching) {
-                        if (!self.watching.hasOwnProperty(k)) continue;
-                        var w = self.watching[k];
+                for (var i = 0; i < self.watching.length; i++) {
+                        var w = self.watching[i];
                         log(w.doc == e.originalTarget);
                         if (w.doc == e.originalTarget) {
-                                log("unwatch: "+w.file.path);
+                                log("unwatch: "+w.file.path+" len:"+self.watching.length);
                                 w.file.remove(false);
-                                delete self.watching[k];
+                                self.watching.splice(i, 1);
+                                if (!self.watching.length) {
+                                        log("end watcher thread. "+self.watcher);
+                                        clearInterval(self.watcher);
+                                        self.watcher = null;
+                                }
                         }
                 }
@@ -95 +100 @@
         watch : function () {
                 var self = this;
-                for (var k in self.watching) {
-                        if (!self.watching.hasOwnProperty(k)) continue;
-                        var w = self.watching[k];
+                for (var i = 0; i < self.watching.length; i++) {
+                        var w = self.watching[i];
                         if (w.time < w.file.lastModifiedTime) {
                                 log("changed:"+w.file.path);