Changeset 36242

Timestamp:

12/23/09 00:38:08 (3 years ago)

Author:

whym

Message:

* add 'all-node' command.
* fix set-pin and unset-pin for correctly displaying/hiding pins

Files:

• lang/javascript/userscripts/ldrize.user.js (modified) (5 diffs)

lang/javascript/userscripts/ldrize.user.js

@@ -247 +247 @@
                   { name: 'current-link',
                         command: function(stdin){return self.getCurrentLink() || []}},
+                  { name: 'all-node',
+                        command: function(stdin){
+                                return self.getParagraphes().list.map(function(i){return i.node;});}},
                   { name: 'clear-pin',
                         command: function(stdin){if(!!stdin) self.clearPinlist(); return stdin}},
@@ -476 +479 @@
   setPin: function(nodes){
           var self = this;
-          this.togglePin(nodes, function(node){self.addPinToPinList(node)});
+          this.togglePin(nodes, function(node){return self.addPinToPinList(node);});
   },
   unsetPin: function(nodes){
           var self = this;
-          this.togglePin(nodes, function(node){self.removePinFromPinList(node)});
+          this.togglePin(nodes, function(node){return self.removePinFromPinList(node);});
   },
   togglePin: function(nodes, fn){
@@ -486 +489 @@
           if(typeof fn == 'undefined'){
                   fn = function(node){
-                          self.removePinFromPinList(node) || self.addPinToPinList(node);
+                          return self.removePinFromPinList(node) || self.addPinToPinList(node);
                   }
           }
           toArray(nodes).forEach(function(node){
-                  fn(node);
-                  self.toggleClassForPin(node);
+                  if ( fn(node) ) {
+                          self.toggleClassForPin(node);
+                  }
           });
           var a = this.html.pinlist_number;
@@ -542 +546 @@
                           xpath = '(descendant-or-self::img | descendant::text()[normalize-space(self::text()) != ""])';
                           matches = $X(xpath, node);
-                          if(!matches.length) return;
+                          if(!matches.length) return false;
                           var height = new Paragraph(matches[0]).y;
                           res = [];
@@ -568 +572 @@
           }
           this.html.pinlist_container.appendChild(paragraph.html);
+          return true;
   },
   removePinFromPinList: function(node){
           var para = this.getParagraphes().find(function(para){return node == para.node});
           var view = para.html;
-          if(!view) return;
+          if(!view) return false;
           var children = toArray(this.html.pinlist_container.childNodes);
           var html = children.find(function(arg){return arg == view});
-          if(!html) return;
+          if(!html) return false;
           this.html.pinlist_container.removeChild(html);
           return true;