Changeset 3702 for lang/perl/Archer

Timestamp:

12/28/07 11:23:43 (11 months ago)

Author:

tokuhirom

Message:

r3655@mnk (orig r305): tokuhiro | 2007-03-05 21:15:35 -0800
perltidied.

Files:

• lang/perl/Archer/lib/Archer/Shell.pm (modified) (7 diffs)

lang/perl/Archer/lib/Archer/Shell.pm

@@ -9 +9 @@
     my ( $class, $args ) = @_;
 
-    return bless { %$args }, $class;
+    return bless {%$args}, $class;
 }
 
 sub run_loop {
-    my ($self, ) = @_;
+    my ( $self, ) = @_;
 
     my $term = Term::ReadLine->new('Archer');
 
-    my $HISTFILE = ($ENV{HOME} || ((getpwuid($<))[7])) . "/.archer_shell_history";
+    my $HISTFILE = ( $ENV{HOME} || ( ( getpwuid($<) )[7] ) )
+        . "/.archer_shell_history";
     my $HISTSIZE = 256;
 
    # this won't work with Term::ReadLine::Perl
    # If there is Term::ReadLine::Gnu, be sure to do : export "PERL_RL=Gnu o=0"
-    eval { $term->stifle_history( $HISTSIZE ); };
-
-    if ( @! ) {
-        $self->{ context }->log( 'debug' => "You will need Term::ReadLine::Gnu" );
-    } else {
+    eval { $term->stifle_history($HISTSIZE); };
+
+    if (@!) {
+        $self->{context}
+            ->log( 'debug' => "You will need Term::ReadLine::Gnu" );
+    }
+    else {
         if ( -f $HISTFILE ) {
-            $term->ReadHistory( $HISTFILE )
-                or $self->{ context }->log( 'warn' => "cannot read history file: $!" );
-        }
-    }
-
-    while ( defined( my $line = $term->readline( 'archer> ' ) ) ) {
+            $term->ReadHistory($HISTFILE)
+                or $self->{context}
+                ->log( 'warn' => "cannot read history file: $!" );
+        }
+    }
+
+    while ( defined( my $line = $term->readline('archer> ') ) ) {
         next if $line =~ /^\s*$/;
-        $self->catch_run( $line );
+        $self->catch_run($line);
     }
 
     print "\n";
 
-    eval { $term->WriteHistory( $HISTFILE ); };
-    if ( @! ) {
-        $self->{context}->log( 'debug' => "perlsh: cannot write history file: $!" );
+    eval { $term->WriteHistory($HISTFILE); };
+    if (@!) {
+        $self->{context}
+            ->log( 'debug' => "perlsh: cannot write history file: $!" );
     }
 
@@ -50 +55 @@
     my ( $self, $cmd ) = @_;
 
-    $self->{ parallel }
-        = $self->{ context }->{ config }->{ global }->{ parallel }
+    $self->{parallel} = $self->{context}->{config}->{global}->{parallel}
         || 'Archer::Parallel::ForkManager';
-    $self->{ parallel }->use or die $@;
+    $self->{parallel}->use or die $@;
 
     if ( $cmd =~ /^on/ ) {
         if ( $cmd =~ /^on\s(.*)\sdo\s(.*)$/ ) {
             $self->process_host( $1, $2 );
-        } else {
+        }
+        else {
             print "[WARNING] error in your syntax, see help\n";
         }
-    } elsif ( $cmd =~ /^with/ ) {
+    }
+    elsif ( $cmd =~ /^with/ ) {
         if ( $cmd =~ /^with\s(.*)\sdo\s(.*)$/ ) {
             $self->process_role( $1, $2 );
-        } else {
+        }
+        else {
             print "[WARNING] error in your syntax, see help\n";
         }
-    } elsif ( $cmd =~ /^help/ ) {
+    }
+    elsif ( $cmd =~ /^help/ ) {
         $self->help();
-    } elsif ( $cmd =~ /^(quit|exit)/ ) {
+    }
+    elsif ( $cmd =~ /^(quit|exit)/ ) {
         print "bye bye\n";
         exit;
-    } elsif ( $cmd =~ /^!/ ) {
+    }
+    elsif ( $cmd =~ /^!/ ) {
         if ( $cmd =~ /^!(\w+)\s?(on|with)?\s?(.*)?$/ ) {
             my $task     = $1;
             my $action   = $2;
             my $machines = $3;
-            if (    defined $action
-                 && defined $machines
-                 && length( $machines ) < 1 )
+            if (   defined $action
+                && defined $machines
+                && length($machines) < 1 )
             {
                 return print "[WARNING] error in your syntax, see help\n";
             }
             my $executed = 0;
-            for
-                my $plugin ( @{ $self->{ config }->{ tasks }->{ process } } )
-            {
-                next if $plugin->{ name } ne $task;
+            for my $plugin ( @{ $self->{config}->{tasks}->{process} } ) {
+                next if $plugin->{name} ne $task;
                 $executed = 1;
                 if ( defined $action ) {
                     if ( $action eq "on" ) {
                         my @hosts = split " ", $machines;
-                        for my $host ( @hosts ) {
+                        for my $host (@hosts) {
                             $self->process_task( $plugin, $host );
                         }
-                    } else {
+                    }
+                    else {
                         my @roles = split " ", $machines;
-                        for my $role ( @roles ) {
-                            for my $host (
-                                          @{ $self->{ servers }->{ $role } } )
-                            {
+                        for my $role (@roles) {
+                            for my $host ( @{ $self->{servers}->{$role} } ) {
                                 $self->process_task( $plugin, $host );
                             }
                         }
                     }
-                } else {
+                }
+                else {
                     for my $host (
-                                   @{  $self->{ servers }
-                                           ->{ $plugin->{ config }->{ role } }
-                                   } )
+                        @{ $self->{servers}->{ $plugin->{config}->{role} } } )
                     {
                         $self->process_task( $plugin, $host );
@@ -118 +124 @@
                 print "[WARNING] unable to find the requested task: $task\n";
             }
-        } else {
+        }
+        else {
             print "[WARNING] error in your syntax\n";
         }
-    } else {
-        $self->process_command( $cmd );
+    }
+    else {
+        $self->process_command($cmd);
     }
 }
@@ -132 +140 @@
 
     # check if hosts are in our config.
-    for my $host ( @hosts ) {
-        for my $role ( keys %{ $self->{ servers } } ) {
-            @hosts = grep ( /$host/, @{ $self->{ servers }->{ $role } } );
-        }
-    }
-
-    if ( @hosts ) {
+    for my $host (@hosts) {
+        for my $role ( keys %{ $self->{servers} } ) {
+            @hosts = grep ( /$host/, @{ $self->{servers}->{$role} } );
+        }
+    }
+
+    if (@hosts) {
         $self->process_command( $cmd, \@hosts );
     }
@@ -149 +157 @@
     my @hosts      = ();
     my @inexistant = ();
-    for my $role ( @roles ) {
-        if ( !defined $self->{ servers }->{ $role } ) {
+    for my $role (@roles) {
+        if ( !defined $self->{servers}->{$role} ) {
             push( @inexistant, $role );
             next;
         }
-        for my $host ( @{ $self->{ servers }->{ $role } } ) {
+        for my $host ( @{ $self->{servers}->{$role} } ) {
             push @hosts, $host;
         }
     }
-    if ( @inexistant ) {
+    if (@inexistant) {
         print "[WARNING] inexisting role(s) for "
             . join( ' ', @inexistant ) . "\n";
@@ -201 +209 @@
     my $class = "Archer::Plugin::$plugin->{module}";
     $class->use or die $@;
-    $class->new( { config  => $plugin->{ config },
-                   project => $self->{ context }->{ project },
-                   server  => $host
-                 } )->run( $self->{ context } );
+    $class->new(
+        {   config  => $plugin->{config},
+            project => $self->{context}->{project},
+            server  => $host
+        }
+    )->run( $self->{context} );
 }
 
@@ -220 +230 @@
 
 sub help {
-    my ( $self ) = @_;
+    my ($self) = @_;
     my $help = <<HELP;
  To quit, just type quit, exit, or press ctrl-D.