Changeset 5794

Timestamp:

01/29/08 17:45:53 (5 years ago)

Author:

daisuke

Message:

lang/perl/DBIx-Replicate; more refactoring

Files:

• lang/perl/DBIx-Replicate/branch/object-refactor/lib/DBIx/Replicate.pm (modified) (7 diffs)

lang/perl/DBIx-Replicate/branch/object-refactor/lib/DBIx/Replicate.pm

@@ -1 +1 @@
 # $Id$
+
 package DBIx::Replicate;
-
 use strict;
 use warnings;
@@ -19 +19 @@
 our $VERSION = '0.01';
 
-__PACKAGE__->mk_accessors($_) for qw(src dest columns extra_cond);
+__PACKAGE__->mk_accessors($_) for qw(src dest columns block extra_cond);
 
 sub new
@@ -25 +25 @@
     my $class = shift;
     my $args  = shift || {};
+    foreach my $p (qw/src dest columns/) {
+        croak "required parameter $p is missing\n"
+            unless $args->{$p};
+    }
+    $args->{block} ||= 1000;
+
+    my $self  = $class->SUPER::new({
+        columns => $args->{columns},
+        block   => $args->{block},
+        src     => $args->{src},
+        dest    => $args->{dest},
+        extra_cond => $args->{extra_cond},
+    });
+        
+    return $self;
+}
+
+
+sub dbix_replicate {
+    my $args = shift;
+
+    $args = { %$args };
+
     foreach my $p (qw/src_table src_conn dest_table dest_conn columns/) {
         croak "required parameter $p is missing\n"
             unless $args->{$p};
     }
-    $args->{block} ||= 1000;
-
-    my $self  = $class->SUPER::new({
-        columns => $args->{columns},
-        block   => $args->{block},
-        src => DBIx::Replicate::Node->new( {
-            table => $args->{src_table},
-            conn  => $args->{src_conn},
-        }),
-        dest => DBIx::Replicate::Node->new( {
-            table => $args->{dest_table},
-            conn  => $args->{dest_conn}
-        }),
-
-        extra_cond => $args->{extra_cond},
+
+    my $src = DBIx::Replicate::Node->new( {
+        table => delete $args->{src_table},
+        conn  => delete $args->{src_conn},
+    } );
+    my $dest = DBIx::Replicate::Node->new( {
+        table => delete $args->{dest_table},
+        conn  => delete $args->{dest_conn}
     });
-        
-    return $self;
-}
-
-
-sub dbix_replicate {
-    my ($args) = @_;
-
-    my $self = DBIx::Replicate->new($args);
-    $self->replicate($args);
+    my $dr = DBIx::Replicate->new( { %$args, src => $src, dest => $dest } );
+    $dr->replicate($args);
 }
 
@@ -65 +73 @@
     my $sql;
     
-    my $src_table = $self->src->table;
+    my $block      = $self->block;
+    my $src_table  = $self->src->table;
     my $dest_table = $self->dest->table;
-    my $src_conn = $self->src->conn;
-    my $dest_conn = $self->dest->conn;
+    my $src_conn   = $self->src->conn;
+    my $dest_conn  = $self->dest->conn;
 
     if ($args->{copy_by}) {
@@ -128 +137 @@
                             @$rows,
                             0,
-                            min(scalar(@$rows), $args->{block}),
+                            min(scalar(@$rows), $block),
                         ),
                     );
@@ -157 +166 @@
         my $order_by = $args->{order_by} || join(',', @$pkey);
         
-        # copy by 'limit $args->{block}'
+        # copy by 'limit $block'
         my ($start_srcconn, $start_destconn) = qw/1 1/;
         while (1) {
             my $start = time;
-            $sql = "select $columns_str from $src_table where $start_srcconn $extra_cond order by $order_by limit $args->{block}";
+            $sql = "select $columns_str from $src_table where $start_srcconn $extra_cond order by $order_by limit $block";
             my $rows = $src_conn->selectall_arrayref(
                 $sql,
@@ -245 +254 @@
     extra_cond   => 'age<20',
   });
+
+
+  # OO interface
+  my $dr = DBIx::Replicate->new(
+    src => DBIx::Replicate::Node->new(...)
+    dest => DBIx::Replicate::Node->new(...)
+    strategy => DBIx::Replicate::Strategy::PK->new()
+  );
+  $dr->replicate();
   
 =head1 DESCRIPTION