Changeset 5801 for lang/perl/DBIx-Replicate

Timestamp:

01/29/08 19:01:14 (5 years ago)

Author:

daisuke

Message:

lang/perl/DBIx-Replicate; use Module::Install, fix up dependecies, remove SQL::Abstract for now

Location:

lang/perl/DBIx-Replicate/trunk

Files:

• Makefile.PL (modified) (1 diff)
• lib/DBIx/Replicate.pm (modified) (1 diff)
• lib/DBIx/Replicate/Node.pm (modified) (2 diffs)
• lib/DBIx/Replicate/Strategy/CopyBy.pm (modified) (3 diffs)
• lib/DBIx/Replicate/Strategy/PK.pm (modified) (2 diffs)

lang/perl/DBIx-Replicate/trunk/Makefile.PL

@@ -1 @@
-use 5.008006;
-use ExtUtils::MakeMaker;
-# See lib/ExtUtils/MakeMaker.pm for details of how to influence
-# the contents of the Makefile that is written.
-WriteMakefile(
-    NAME              => 'DBIx::Replicate',
-    VERSION_FROM      => 'lib/DBIx/Replicate.pm', # finds $VERSION
-    PREREQ_PM         => {}, # e.g., Module::Name => 1.1
-    ($] >= 5.005 ?     ## Add these new keywords supported since 5.005
-      (ABSTRACT_FROM  => 'lib/DBIx/Replicate.pm', # retrieve abstract from module
-       AUTHOR         => '奥 一穂 <kazuho@apple.com>') : ()),
-);
+use strict;
+use inc::Module::Install;
+
+name('DBIx-Replicate');
+all_from('lib/DBIx/Replicate.pm');
+
+requires 'Carp::Clan';
+requires 'Class::Accessor::Fast';
+requires 'Exporter', '5.60';
+requires 'List::Util';
+requires 'DBI';
+requires 'UNIVERSAL::require';
+
+auto_install;
+WriteAll;

lang/perl/DBIx-Replicate/trunk/lib/DBIx/Replicate.pm

@@ -4 +4 @@
 use strict;
 use warnings;
-use AutoLoader qw/AUTOLOAD/;
 use Carp::Clan;
 use DBI;
 use DBIx::Replicate::Node;
-use Time::HiRes qw/time sleep/;
 use UNIVERSAL::require;
 use Exporter 'import';

lang/perl/DBIx-Replicate/trunk/lib/DBIx/Replicate/Node.pm

@@ -5 +5 @@
 use warnings;
 use base qw(Class::Accessor::Fast);
-use Carp();
+use Carp::Clan;
 use UNIVERSAL::require;
 
-__PACKAGE__->mk_accessors($_) for qw(conn sql_maker table);
+__PACKAGE__->mk_accessors($_) for qw(conn table); # sql_maker
 
 sub new
@@ -16 +16 @@
 
     foreach my $p (qw/conn table/) {
-        Carp::croak "required parameter $p is missing\n"
+        croak "required parameter $p is missing\n"
             unless $args->{$p};
     }
     my $conn = $args->{conn};
     my $table = $args->{table};
-    my $sql_maker_class = $args->{sql_maker_class} || 'SQL::Abstract::Limit';
-    my $sql_maker_args  = $args->{sql_maker_args} || { limit_dialect => $conn };
+#    my $sql_maker_class = $args->{sql_maker_class} || 'SQL::Abstract::Limit';
+#    my $sql_maker_args  = $args->{sql_maker_args} || { limit_dialect => $conn };
 
-    $sql_maker_class->require or die;
-    my $sql_maker = $sql_maker_class->new( %{ $sql_maker_args } );
+#    $sql_maker_class->require or die;
+#    my $sql_maker = $sql_maker_class->new( %{ $sql_maker_args } );
     my $self  = $class->SUPER::new({
         conn => $conn,
         table => $table,
-        sql_maker => $sql_maker
+#        sql_maker => $sql_maker
     });
     $self;

lang/perl/DBIx-Replicate/trunk/lib/DBIx/Replicate/Strategy/CopyBy.pm

@@ -4 +4 @@
 use strict;
 use warnings;
-use Carp ();
+use Carp::Clan;
 use List::Util qw/min/;
 
@@ -16 +16 @@
 
     foreach my $p qw(copy_by) {
-        Carp::croak(ref($self) . ": required parameter $p is missing\n")
+        croak(ref($self) . ": required parameter $p is missing\n")
             unless $args->{$p};
     }
@@ -35 +35 @@
 
     # copy using 'where key=x'
-    Carp::croak "multi-column per-value copy not supported\n"
+    croak "multi-column per-value copy not supported\n"
         unless @{$args->{copy_by}} == 1;
-    Carp::croak "extra_cond not supported by copy_by\n"
+    croak "extra_cond not supported by copy_by\n"
         if $extra_cond;
     my $key_col = $args->{copy_by}->[0];

lang/perl/DBIx-Replicate/trunk/lib/DBIx/Replicate/Strategy/PK.pm

@@ -4 +4 @@
 use strict;
 use warnings;
-use Carp();
+use Carp::Clan;
 
 sub new { bless {}, shift }
@@ -15 +15 @@
 
     foreach my $p qw(primary_key) {
-        Carp::croak(ref($self) . ": required parameter $p is missing\n")
+        croak(ref($self) . ": required parameter $p is missing\n")
             unless $args->{$p};
     }