Changeset 8672

Timestamp:

04/02/08 20:34:30 (5 years ago)

Author:

yappo

Message:

lang/perl/HTTP-MobileAttribute?: accessor っぽいの実装したよ

Location:

lang/perl/HTTP-MobileAttribute/trunk/lib/HTTP/MobileAttribute

Files:

• Plugin.pm (modified) (1 diff)
• Plugin/Default/DoCoMo.pm (modified) (1 diff)

lang/perl/HTTP-MobileAttribute/trunk/lib/HTTP/MobileAttribute/Plugin.pm

@@ -3 +3 @@
 use warnings;
 use base qw/Class::Component::Plugin/;
+
+sub mk_register_accessors {
+    my $self = shift;
+    my $c     = shift;
+    my $class = ref $self;
+
+    for my $method (@_) {
+        no strict 'refs';
+        *{"$class\::$method"} = sub { shift->{$method} } unless *{"$class\::$method"}{CODE};
+        $c->register_method( $method => $self );
+    }
+}
 1;

lang/perl/HTTP-MobileAttribute/trunk/lib/HTTP/MobileAttribute/Plugin/Default/DoCoMo.pm

@@ -9 +9 @@
     my ( $self, $c ) = @_;
     return unless $c->carrier_longname eq 'DoCoMo';
+    $self->mk_register_accessors( $c => qw/version model status bandwidth serial_number is_foma card_id xhtml_compliant comment/);
 
     $self->parse( $c );
 }
 
-# FIXME: ここなんとかして。どうにかして。なんか anonymous function だと Attribute がうまくあたらないからとりあえずこれで。
-for my $method (qw/version model status bandwidth serial_number is_foma card_id xhtml_compliant comment/) {
-    eval qq! sub $method :MobileMethod('DoCoMo') { shift->{$method} }; !; ## no critic.
-    die $@ if $@;
-}
 
 sub name : MobileMethod('DoCoMo') { shift->{name} }