Changeset 9993

Timestamp:

04/20/08 18:47:56 (5 years ago)

Author:

nyarla

Message:

lang/perl/Class-Hookable: I implemented run_hook and call_method methods.

Location:

lang/perl/Class-Hookable/trunk

Files:

• lib/Class/Hookable.pm (modified) (4 diffs)
• t/50_call (moved) (moved from lang/perl/Class-Hookable/trunk/t/04_call)
• t/50_call/00_run_hook.t (modified) (2 diffs)
• t/50_call/01_call_method.t (modified) (2 diffs)

lang/perl/Class-Hookable/trunk/lib/Class/Hookable.pm

@@ -381 +381 @@
     }
 
-
     my @results;
 
-    my $context = ( defined $self->hookable_context ) ? $self->hookable_context : $self ;
-
-    for my $action ( $self->registered_callbacks( $hook ) ) {
-        if ( $self->hookable_call_filter( 'run_hook', $hook, $args, $action ) ) {
+    my $context = ( defined $self->class_hookable_context ) ? $self->class_hookable_context : $self ;
+
+    for my $action ( @{ $self->class_hookable_hooks->{$hook} || [] } ) {
+        if ( $self->class_hookable_filter( 'run_hook', $hook, $action, $args ) ) {
             my $plugin = $action->{'plugin'};
             my $result = $action->{'callback'}->( $plugin, $context, $args );
             $callback->( $result ) if ( $callback );
             if ( $once ) {
-                return $result if ( defined $once );
+                return $result if ( defined $result );
             }
             else {
@@ -416 +415 @@
     }
 
-    my $context = ( defined $self->hookable_context )
-                ? $self->hookable_context
+    my $context = ( defined $self->class_hookable_context )
+                ? $self->class_hookable_context
                 : $self ;
 
-    my $action = $self->registered_function( $method );
+    my $action  = $self->class_hookable_methods->{$method};
     return if ( ! $action );
 
-    if ( $self->hookable_call_filter( 'call_method', $method, $args, $action ) ) {
+    if ( $self->class_hookable_filter( 'call_method', $method, $action, $args ) ) {
         my ( $plugin, $function ) = @{ $action }{qw( plugin function )};
         my $result = $function->( $plugin, $context, $args );
@@ -596 +595 @@
 =back
 
-B<Arguments of C<$hook-E<gt>hookable_call_filter>>:
-
-  $hook->hookable_call_filter( 'run_hook', $hook, $args, $action );
-
-Only when C<$hook-E<gt>hookable_call_filter( 'run_hook', $hook, $args, $action )> has returned truth,
+Only when C<$hook-E<gt>class_hookable_filter( 'run_hook', $hook, $action, $args )> has returned truth,
 this method calls callback.
 
-Please see L<"hookable_call_filter"> about C<$hook-E<gt>hookable_call_filter>.
-
-=over
-
-=item 'run_hook'
-
-C<'run_hook'> is filter name.
-
-=item C<$hook>
-
-The hook name specified by the run_hook method.
-
-=item C<$args>
-
-The argument specified by the run_hook method.
-
-=item C<$action>
-
-  my ( $plugin, $callback ) = @{ $action }{qw( plugin callback )};
-
-The hash reference including the plugin and the callback.
-
-=back
+Please see L<"class_hookable_filter"> about C<$hook-E<gt>class_hookable_filter>.
 
 =head2 run_hook_once
@@ -687 +660 @@
 =back
 
-B<Arguments of C<$hook-E<gt>hookable_call_filter>>:
-
-  $hook->hookable_call_filter( 'call_method', $method, $args, $action );
-
-Only when C<$hook-E<gt>hookable_call_filter( 'call_method', $method, $args, $action )> has returned truth,
+Only when C<$hook-E<gt>class_hookable_filter( 'call_method', $method, $action, $args )> has returned truth,
 this method calls function.
 
-Please see L<"hookable_call_filter"> about C<$hook-E<gt>hookable_call_filter>.
-
-=over
-
-=item C<'call_method'>
-
-C<'call_method'> is filter name.
-
-=item C<$method>
-
-The function name specified by the call_method method.
-
-=item C<$args>
-
-The argument specified by the call_method method.
-
-=item C<$action>
-
-  my ( $plugin, $function ) = @{ $action }{qw( plugin function )};
-
-The hash reference including the plugin and the function.
-
-=back
+Please see L<"class_hookable_filter"> about C<$hook-E<gt>class_hookable_filter>.
 
 =head1 FILTER METHODS

lang/perl/Class-Hookable/trunk/t/50_call/00_run_hook.t

@@ -53 +53 @@
 # -- context test -------------------- #
 
-$hook->hookable_context( Context->new );
+$hook->class_hookable_context( Context->new );
 
 $hook->run_hook_once('context');
@@ -65 +65 @@
 # -- dispatch_plugin test ------------ #
 
-$hook->hookable_set_filter(
+$hook->class_hookable_set_filter(
     'run_hook' => sub {
-        my ( $self, $filter, $hook, $args, $action ) = @_;
+        my ( $self, $filter, $hook, $action, $args ) = @_;
 
         isa_ok( $self, 'Class::Hookable' );

lang/perl/Class-Hookable/trunk/t/50_call/01_call_method.t

@@ -43 +43 @@
 # -- context test -------------------- #
 
-$hook->hookable_context( Context->new );
+$hook->class_hookable_context( Context->new );
 $hook->call_method('context');
 
@@ -53 +53 @@
 # -- filter test --------------------- #
 
-$hook->hookable_set_filter(
+$hook->class_hookable_set_filter(
     'call_method' => sub {
-        my ( $self, $filter, $method, $args, $action ) = @_;
+        my ( $self, $filter, $method, $action, $args ) = @_;
 
         isa_ok( $self, 'Class::Hookable' );